archive mirror
 help / color / mirror / Atom feed
From: Alice Ryhl <>
To: Danilo Krummrich <>
Subject: Re: [PATCH v2] rust: str: add {make,to}_{upper,lower}case() to CString
Date: Tue, 13 Feb 2024 15:19:29 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Jan 30, 2024 at 3:38 AM Danilo Krummrich <> wrote:
> Add functions to convert a CString to upper- / lowercase, either
> in-place or by creating a copy of the original CString.
> Naming followes the one from the Rust stdlib, where functions starting
> with 'to' create a copy and functions starting with 'make' perform an
> in-place conversion.
> This is required by the Nova project (GSP only Rust successor of
> Nouveau) to convert stringified enum values (representing different GPU
> chipsets) to strings in order to generate the corresponding firmware
> paths. See also [1].
> [1]
> Signed-off-by: Danilo Krummrich <>

Not a deal-breaker, but this comment of mine still applies:


  parent reply	other threads:[~2024-02-13 14:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30  2:35 [PATCH v2] rust: str: add {make,to}_{upper,lower}case() to CString Danilo Krummrich
2024-02-13 14:12 ` Danilo Krummrich
2024-02-13 14:19 ` Alice Ryhl [this message]
2024-02-14 17:20   ` Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).