rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] rust: bindings: Order headers alphabetically
@ 2024-02-16 15:27 Mika Westerberg
  2024-02-16 15:49 ` Miguel Ojeda
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mika Westerberg @ 2024-02-16 15:27 UTC (permalink / raw)
  To: rust-for-linux
  Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
	Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg,
	Alice Ryhl, Mika Westerberg

As the comment on top of the file suggests, sort the headers
alphabetically.

No functional changes.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 rust/bindings/bindings_helper.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/rust/bindings/bindings_helper.h b/rust/bindings/bindings_helper.h
index 936651110c39..65b98831b975 100644
--- a/rust/bindings/bindings_helper.h
+++ b/rust/bindings/bindings_helper.h
@@ -12,10 +12,10 @@
 #include <linux/jiffies.h>
 #include <linux/mdio.h>
 #include <linux/phy.h>
-#include <linux/slab.h>
 #include <linux/refcount.h>
-#include <linux/wait.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/wait.h>
 #include <linux/workqueue.h>
 
 /* `bindgen` gets confused at certain things. */
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: bindings: Order headers alphabetically
  2024-02-16 15:27 [PATCH] rust: bindings: Order headers alphabetically Mika Westerberg
@ 2024-02-16 15:49 ` Miguel Ojeda
  2024-02-16 16:43 ` Alice Ryhl
  2024-02-18 20:23 ` Miguel Ojeda
  2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2024-02-16 15:49 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho,
	Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl, Roy Matero

On Fri, Feb 16, 2024 at 4:27 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> As the comment on top of the file suggests, sort the headers
> alphabetically.

This is https://github.com/Rust-for-Linux/linux/issues/1002 and there
was https://lore.kernel.org/rust-for-linux/20230426224748.34056-1-materoy@proton.me/
(Cc'ing Roy).

But since the v2 never arrived, I guess we will just go with this one.

Thanks!

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: bindings: Order headers alphabetically
  2024-02-16 15:27 [PATCH] rust: bindings: Order headers alphabetically Mika Westerberg
  2024-02-16 15:49 ` Miguel Ojeda
@ 2024-02-16 16:43 ` Alice Ryhl
  2024-02-18 20:23 ` Miguel Ojeda
  2 siblings, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2024-02-16 16:43 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho,
	Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg

On Fri, Feb 16, 2024 at 4:27 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> As the comment on top of the file suggests, sort the headers
> alphabetically.
>
> No functional changes.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] rust: bindings: Order headers alphabetically
  2024-02-16 15:27 [PATCH] rust: bindings: Order headers alphabetically Mika Westerberg
  2024-02-16 15:49 ` Miguel Ojeda
  2024-02-16 16:43 ` Alice Ryhl
@ 2024-02-18 20:23 ` Miguel Ojeda
  2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2024-02-18 20:23 UTC (permalink / raw)
  To: Mika Westerberg
  Cc: rust-for-linux, Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho,
	Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin,
	Andreas Hindborg, Alice Ryhl

On Fri, Feb 16, 2024 at 4:27 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> As the comment on top of the file suggests, sort the headers
> alphabetically.
>
> No functional changes.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Applied to `rust-next` with `Link:` added -- thanks everyone!

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-18 20:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-16 15:27 [PATCH] rust: bindings: Order headers alphabetically Mika Westerberg
2024-02-16 15:49 ` Miguel Ojeda
2024-02-16 16:43 ` Alice Ryhl
2024-02-18 20:23 ` Miguel Ojeda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).