rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Gioh Kim <gi-oh.kim@ionos.com>
Cc: rust-for-linux <rust-for-linux@vger.kernel.org>,
	Gioh Kim <gurugio@gmail.com>
Subject: Re: [RFC] rust: kernel: ioctl returns ENOTTY if not implemented
Date: Mon, 23 Aug 2021 12:47:18 +0200	[thread overview]
Message-ID: <CANiq72=zVfJskCzhDNGjSVZiHU8QJrEJhQEdO8o=-YU=jrKneQ@mail.gmail.com> (raw)
In-Reply-To: <20210819204422.64595-1-gi-oh.kim@ionos.com>

Hi Gioh,

On Thu, Aug 19, 2021 at 10:45 PM Gioh Kim <gi-oh.kim@ionos.com> wrote:
>
> From: Gioh Kim <gurugio@gmail.com>
>
> According to fs/ioctl.c, ioctl system call first test the cmd
> value with do_vfs_ioctl. If the cmd is not supported command,
> it calls vfs_ioctl. Then vfs_ioctl returns ENOTTY if ioctl is
> not implemented.
>
> Signed-off-by: Gioh Kim <gurugio@gmail.com>

Thanks! Applying it.

(By the way, always try to match the `From` -- I understand you are
sending this as a personal contribution vs. your other commits in the
kernel).

Cheers,
Miguel

      parent reply	other threads:[~2021-08-23 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-19 20:44 [RFC] rust: kernel: ioctl returns ENOTTY if not implemented Gioh Kim
2021-08-21 15:34 ` Wei Liu
2021-08-23 10:47 ` Miguel Ojeda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72=zVfJskCzhDNGjSVZiHU8QJrEJhQEdO8o=-YU=jrKneQ@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=gi-oh.kim@ionos.com \
    --cc=gurugio@gmail.com \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).