From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: rust-for-linux <rust-for-linux@vger.kernel.org>,
Miguel Ojeda <ojeda@kernel.org>
Subject: Re: help installing the correct version of bindgen
Date: Wed, 25 May 2022 01:39:29 +0200 [thread overview]
Message-ID: <CANiq72km2ULoGWh8ouYaOxH6+nSRbhC8bWHsZVDv26u9HuSB9g@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdkm+CQ3rd6YF_iJOegjZPUuwPfGVp7DxB6JozsKZa5npQ@mail.gmail.com>
On Wed, May 25, 2022 at 12:28 AM Nick Desaulniers
<ndesaulniers@google.com> wrote:
>
> There is a little bit of error handling; for my issue most of the
> error message gets swallowed as shown above. With the below diff:
Yeah, that is what I meant by having a message, or as you did, just
call it and let it print its own error. Thanks!
> So it looks like the error is not fixed in 1.2.0 release of clang-sys.
> Left more comments in
> https://github.com/KyleMayes/clang-sys/issues/138.
Thanks for following it up.
> I'd like to find out why dependencies are borked first, before
> resorting to env vars.
Definitely, but I suggested because it is good to know that solves it
so that there is not something else going on.
> does seem to work though.
Great -- thanks for trying it.
> error[E0063]: missing field `uring_cmd` in initializer of
> `bindings_raw::file_operations`
> ...
> better than nothing. :) (I just reapplied your series on top of
> a6b450573b912316ad36262bfc70e7c3870c56d1)
Yeah, a few hours ago ee692a21e9bf ("fs,io_uring: add infrastructure
for uring-cmd") got merged, which added a field to `struct
file_operations` so we need changes on the Rust side too.
If you try on top of v5.18 it should work, or if you apply a diff like
(may be wrapped):
```diff
diff --git a/rust/kernel/file.rs b/rust/kernel/file.rs
index e1b3b324bb3d..4c6513702cfa 100644
--- a/rust/kernel/file.rs
+++ b/rust/kernel/file.rs
@@ -534,6 +534,7 @@ impl<A: OpenAdapter<T::OpenData>, T: Operations>
OperationsVtable<A, T> {
} else {
None
},
+ uring_cmd: None,
write_iter: if T::TO_USE.write_iter {
Some(Self::write_iter_callback)
} else {
```
Cheers,
Miguel
next prev parent reply other threads:[~2022-05-24 23:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 20:28 help installing the correct version of bindgen Nick Desaulniers
2022-05-24 12:08 ` Miguel Ojeda
2022-05-24 22:28 ` Nick Desaulniers
2022-05-24 23:39 ` Miguel Ojeda [this message]
2022-05-25 0:30 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANiq72km2ULoGWh8ouYaOxH6+nSRbhC8bWHsZVDv26u9HuSB9g@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).