From: "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To: "Jamie Cunliffe" <Jamie.Cunliffe@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<rust-for-linux@vger.kernel.org>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, <steve.capper@arm.com>
Subject: Re: [PATCH 3/3] arm64: rust: Disable neon and fp target features.
Date: Wed, 25 Jan 2023 20:55:42 +0100 [thread overview]
Message-ID: <CQ1JAF0JNEKI.1LAPS4TXTVODQ@vincent> (raw)
In-Reply-To: <20230125163739.3798252-4-Jamie.Cunliffe@arm.com>
On Wed Jan 25, 2023 at 5:37 PM CET, Jamie Cunliffe wrote:
> Disable the neon and fp target features to avoid fp & simd
> registers. The use of fp-armv8 will cause a warning from rustc about
> an unknown feature that is specified. The target feature is still
> passed through to LLVM, this behaviour is documented as part of the
> warning. This will be fixed in a future version of the rustc
> toolchain.
>
> Signed-off-by: Jamie Cunliffe <Jamie.Cunliffe@arm.com>
Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
> ---
> arch/arm64/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index b53ab6aa2dfe..33ae20fc3f56 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -41,6 +41,8 @@ KBUILD_CFLAGS += -mgeneral-regs-only \
> KBUILD_CFLAGS += $(call cc-disable-warning, psabi)
> KBUILD_AFLAGS += $(compat_vdso)
>
> +KBUILD_RUSTFLAGS += -C target-feature="-neon,-fp-armv8"
> +
> KBUILD_CFLAGS += $(call cc-option,-mabi=lp64)
> KBUILD_AFLAGS += $(call cc-option,-mabi=lp64)
>
> --
> 2.30.2
next prev parent reply other threads:[~2023-01-25 19:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 16:37 [PATCH 0/3] Rust enablement for AArch64 Jamie Cunliffe
2023-01-25 16:37 ` [PATCH 1/3] arm64: rust: Enable Rust support " Jamie Cunliffe
2023-01-25 19:50 ` Vincenzo Palazzo
2023-01-25 19:56 ` Vincenzo Palazzo
2023-01-26 16:35 ` Will Deacon
2023-01-26 17:56 ` Miguel Ojeda
2023-01-31 16:19 ` Will Deacon
2023-01-31 16:49 ` Björn Roy Baron
2023-01-31 18:55 ` Miguel Ojeda
2023-04-18 15:06 ` Jamie Cunliffe
2023-01-27 14:09 ` Gary Guo
2023-05-02 13:41 ` Asahi Lina
2023-01-25 16:37 ` [PATCH 2/3] arm64: rust: Enable PAC support for Rust Jamie Cunliffe
2023-01-25 19:54 ` Vincenzo Palazzo
2023-01-25 16:37 ` [PATCH 3/3] arm64: rust: Disable neon and fp target features Jamie Cunliffe
2023-01-25 17:49 ` Miguel Ojeda
2023-01-25 19:55 ` Vincenzo Palazzo [this message]
2023-01-26 16:37 ` Will Deacon
2023-01-25 18:01 ` [PATCH 0/3] Rust enablement for AArch64 Miguel Ojeda
2023-03-07 9:32 ` Asahi Lina
2023-03-07 12:17 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CQ1JAF0JNEKI.1LAPS4TXTVODQ@vincent \
--to=vincenzopalazzodev@gmail.com \
--cc=Jamie.Cunliffe@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=steve.capper@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).