From: "Björn Roy Baron" <bjorn3_gh@protonmail.com>
To: Vinay Varma <varmavinaym@gmail.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>,
Wedson Almeida Filho <wedsonaf@gmail.com>,
Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH] scripts: `make rust-analyzer` for out-of-tree modules
Date: Fri, 20 Jan 2023 13:17:33 +0000 [thread overview]
Message-ID: <MzQKRFS7tVFtse-EaI1QkIlyz1NMk56vSPdOmY0M3sgG4RHsFUMubaEffsPxSDyFG9dKfhJcBxN4pYYf3R95IuAVd1Ne0P2pMqXHC0dOTLw=@protonmail.com> (raw)
In-Reply-To: <20230118160220.776302-1-varmavinaym@gmail.com>
------- Original Message -------
On Wednesday, January 18th, 2023 at 17:02, Vinay Varma <varmavinaym@gmail.com> wrote:
> Adds support for out-of-tree rust modules to use the `rust-analyzer`
> make target to generate the rust-project.json file.
>
> The change involves adding an optional parameter `external_src` to the
> `generate_rust_analyzer.py` which expects the path to the out-of-tree
> module's source directory. When this parameter is passed, I have chosen
> not to add the non-core modules (samples and drivers) into the result
> since these are not expected to be used in third party modules. Related
> changes are also made to the Makefile and rust/Makefile allowing the
> `rust-analyzer` target to be used for out-of-tree modules as well.
>
> Signed-off-by: Vinay Varma varmavinaym@gmail.com
>
> ---
I tested this with https://github.com/Rust-for-Linux/rust-out-of-tree-module using "make -C ../rust-for-linux M=$(pwd) rust-analyzer". It produces a rust-project.json file, however it misses the actual rust_out_of_tree crate. This is due to the fact that generate_rust_analyzer.py only checks Makefile to find the crate roots, but rust-out-of-tree-module defines it in Kbuild instead.
Apart from this issue, all paths I checked in the generated rust-project.json are correct.
Cheers,
Bjorn
next prev parent reply other threads:[~2023-01-20 13:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 16:02 [PATCH] scripts: `make rust-analyzer` for out-of-tree modules Vinay Varma
2023-01-19 19:12 ` Miguel Ojeda
2023-01-20 13:17 ` Björn Roy Baron [this message]
2023-01-20 13:35 ` Miguel Ojeda
2023-01-21 5:25 ` [PATCH v2] " Vinay Varma
2023-01-21 9:18 ` Masahiro Yamada
2023-03-07 15:28 ` Vinay Varma
2023-03-07 19:55 ` Miguel Ojeda
2023-04-07 23:59 ` Miguel Ojeda
2023-04-11 9:17 ` [PATCH v5] " Vinay Varma
2023-08-02 17:37 ` Miguel Ojeda
2023-01-21 16:40 ` [PATCH v2] " Björn Roy Baron
2023-03-07 12:24 ` Miguel Ojeda
2023-03-07 14:42 ` [PATCH v3] " Vinay Varma
2023-03-07 15:55 ` [PATCH v4] " Vinay Varma
2023-01-20 15:21 ` [PATCH] " Alice Ferrazzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='MzQKRFS7tVFtse-EaI1QkIlyz1NMk56vSPdOmY0M3sgG4RHsFUMubaEffsPxSDyFG9dKfhJcBxN4pYYf3R95IuAVd1Ne0P2pMqXHC0dOTLw=@protonmail.com' \
--to=bjorn3_gh@protonmail.com \
--cc=alex.gaynor@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=varmavinaym@gmail.com \
--cc=wedsonaf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).