rust-for-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] printk: make suppress_panic_printk static
@ 2022-02-16  3:19 Jiapeng Chong
  2022-02-16  3:46 ` Sergey Senozhatsky
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jiapeng Chong @ 2022-02-16  3:19 UTC (permalink / raw)
  To: pmladek
  Cc: senozhatsky, rostedt, john.ogness, keescook, anton, ccross,
	tony.luck, ojeda, alex.gaynor, wedsonaf, linux-kernel,
	rust-for-linux, Jiapeng Chong, Abaci Robot

This symbol is not used outside of printk.c, so marks it static.

Fix the following sparse warning:

kernel/printk/printk.c:100:19: warning: symbol 'suppress_panic_printk'
was not declared. Should it be static?

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 kernel/printk/printk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 7a9eace19191..703397cadd01 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -97,7 +97,7 @@ int __read_mostly suppress_printk;
  * During panic, heavy printk by other CPUs can delay the
  * panic and risk deadlock on console resources.
  */
-int __read_mostly suppress_panic_printk;
+static int __read_mostly suppress_panic_printk;
 
 #ifdef CONFIG_LOCKDEP
 static struct lockdep_map console_lock_dep_map = {
-- 
2.20.1.7.g153144c


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] printk: make suppress_panic_printk static
  2022-02-16  3:19 [PATCH] printk: make suppress_panic_printk static Jiapeng Chong
@ 2022-02-16  3:46 ` Sergey Senozhatsky
  2022-02-16 10:35 ` Miguel Ojeda
  2022-02-21 16:03 ` Petr Mladek
  2 siblings, 0 replies; 4+ messages in thread
From: Sergey Senozhatsky @ 2022-02-16  3:46 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: pmladek, senozhatsky, rostedt, john.ogness, keescook, anton,
	ccross, tony.luck, ojeda, alex.gaynor, wedsonaf, linux-kernel,
	rust-for-linux, Abaci Robot

On (22/02/16 11:19), Jiapeng Chong wrote:
> This symbol is not used outside of printk.c, so marks it static.
> 
> Fix the following sparse warning:
> 
> kernel/printk/printk.c:100:19: warning: symbol 'suppress_panic_printk'
> was not declared. Should it be static?
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] printk: make suppress_panic_printk static
  2022-02-16  3:19 [PATCH] printk: make suppress_panic_printk static Jiapeng Chong
  2022-02-16  3:46 ` Sergey Senozhatsky
@ 2022-02-16 10:35 ` Miguel Ojeda
  2022-02-21 16:03 ` Petr Mladek
  2 siblings, 0 replies; 4+ messages in thread
From: Miguel Ojeda @ 2022-02-16 10:35 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: Petr Mladek, Sergey Senozhatsky, Steven Rostedt, John Ogness,
	Kees Cook, anton, ccross, Tony Luck, Miguel Ojeda, Alex Gaynor,
	Wedson Almeida Filho, linux-kernel, rust-for-linux, Abaci Robot

On Wed, Feb 16, 2022 at 4:20 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> This symbol is not used outside of printk.c, so marks it static.
>
> Fix the following sparse warning:
>
> kernel/printk/printk.c:100:19: warning: symbol 'suppress_panic_printk'
> was not declared. Should it be static?
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

It could be good to mention this is based on -next.

Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Cheers,
Miguel

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] printk: make suppress_panic_printk static
  2022-02-16  3:19 [PATCH] printk: make suppress_panic_printk static Jiapeng Chong
  2022-02-16  3:46 ` Sergey Senozhatsky
  2022-02-16 10:35 ` Miguel Ojeda
@ 2022-02-21 16:03 ` Petr Mladek
  2 siblings, 0 replies; 4+ messages in thread
From: Petr Mladek @ 2022-02-21 16:03 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: senozhatsky, rostedt, john.ogness, keescook, anton, ccross,
	tony.luck, ojeda, alex.gaynor, wedsonaf, linux-kernel,
	rust-for-linux, Abaci Robot

On Wed 2022-02-16 11:19:57, Jiapeng Chong wrote:
> This symbol is not used outside of printk.c, so marks it static.
> 
> Fix the following sparse warning:
> 
> kernel/printk/printk.c:100:19: warning: symbol 'suppress_panic_printk'
> was not declared. Should it be static?
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

The patch has been committed into printk/linux.git,
branch for-5.18-panic-deadlocks.

Best Regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-21 16:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16  3:19 [PATCH] printk: make suppress_panic_printk static Jiapeng Chong
2022-02-16  3:46 ` Sergey Senozhatsky
2022-02-16 10:35 ` Miguel Ojeda
2022-02-21 16:03 ` Petr Mladek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).