From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, andriy.shevchenko@intel.com,
Keyon Jie <yang.jie@linux.intel.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
liam.r.girdwood@linux.intel.com, vkoul@kernel.org,
broonie@kernel.org, Alan Cox <alan@linux.intel.com>,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v4 14/14] ASoC: SOF: Add utils
Date: Thu, 14 Feb 2019 14:37:37 +0100 [thread overview]
Message-ID: <s5h36oqze1q.wl-tiwai@suse.de> (raw)
In-Reply-To: <s5h4l96ze8l.wl-tiwai@suse.de>
On Thu, 14 Feb 2019 14:33:30 +0100,
Takashi Iwai wrote:
>
> On Wed, 13 Feb 2019 23:07:34 +0100,
> Pierre-Louis Bossart wrote:
> >
> > +void sof_io_write(struct snd_sof_dev *sdev, void __iomem *addr, u32 value)
> > +{
> > + writel(value, addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_write);
> > +
> > +u32 sof_io_read(struct snd_sof_dev *sdev, void __iomem *addr)
> > +{
> > + return readl(addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_read);
> > +
> > +void sof_io_write64(struct snd_sof_dev *sdev, void __iomem *addr, u64 value)
> > +{
> > + writeq(value, addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_write64);
> > +
> > +u64 sof_io_read64(struct snd_sof_dev *sdev, void __iomem *addr)
> > +{
> > + return readq(addr);
> > +}
> > +EXPORT_SYMBOL(sof_io_read64);
>
> What's the merit of these wrappers?
> Even if they are good for consistency, they can be well inlined.
OK, now it's clear after reading the other series.
It'd be helpful to add some notes mentioning that these are commonly
set to snd_sof_dsp_ops.
thanks,
Takashi
next prev parent reply other threads:[~2019-02-14 13:37 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 22:07 [PATCH v4 00/14] ASoC: Sound Open Firmware (SOF) core Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 01/14] ASoC: SOF: Add Sound Open Firmware driver core Pierre-Louis Bossart
2019-02-14 9:25 ` Takashi Iwai
2019-02-14 14:53 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-19 15:38 ` Mark Brown
2019-02-20 14:35 ` Pierre-Louis Bossart
2019-02-20 16:26 ` Mark Brown
2019-02-20 21:32 ` Pierre-Louis Bossart
2019-02-21 18:47 ` Mark Brown
2019-02-22 0:08 ` Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 02/14] ASoC: SOF: Add Sound Open Firmware KControl support Pierre-Louis Bossart
2019-02-14 9:30 ` Takashi Iwai
2019-02-14 14:35 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-14 15:21 ` Takashi Iwai
2019-02-13 22:07 ` [PATCH v4 03/14] ASoC: SOF: Add driver debug support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 04/14] ASoC: SOF: Add support for IPC IO between DSP and Host Pierre-Louis Bossart
2019-02-14 11:52 ` Takashi Iwai
2019-02-14 14:56 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-20 17:31 ` Mark Brown
2019-02-13 22:07 ` [PATCH v4 05/14] ASoC: SOF: Add PCM operations support Pierre-Louis Bossart
2019-02-14 11:20 ` Takashi Iwai
2019-02-14 15:07 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-14 20:42 ` Pierre-Louis Bossart
2019-02-18 15:51 ` Daniel Baluta
2019-02-13 22:07 ` [PATCH v4 06/14] ASoC: SOF: Add support for loading topologies Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 07/14] ASoC: SOF: Add DSP firmware logger support Pierre-Louis Bossart
2019-02-14 13:19 ` Takashi Iwai
2019-02-14 15:13 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-20 17:44 ` Mark Brown
2019-02-20 20:18 ` Pierre-Louis Bossart
2019-02-21 12:29 ` Andy Shevchenko
2019-02-21 14:57 ` Pierre-Louis Bossart
2019-02-21 15:04 ` Mark Brown
2019-02-13 22:07 ` [PATCH v4 08/14] ASoC: SOF: Add DSP HW abstraction operations Pierre-Louis Bossart
2019-02-14 13:21 ` Takashi Iwai
2019-02-14 15:22 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-14 13:45 ` Andy Shevchenko
2019-02-14 15:21 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 09/14] ASoC: SOF: Add firmware loader support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 10/14] ASoC: SOF: Add userspace ABI support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 11/14] ASoC: SOF: Add PM support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 12/14] ASoC: SOF: Add Nocodec machine driver support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 13/14] ASoC: SOF: Add xtensa support Pierre-Louis Bossart
2019-02-13 22:07 ` [PATCH v4 14/14] ASoC: SOF: Add utils Pierre-Louis Bossart
2019-02-14 13:33 ` Takashi Iwai
2019-02-14 13:37 ` Takashi Iwai [this message]
2019-02-18 20:03 ` [v4,00/14] ASoC: Sound Open Firmware (SOF) core Xiang Xiao
2019-02-19 9:49 ` [alsa-devel] " Srinivas Kandagatla
2019-02-19 9:49 ` Srinivas Kandagatla
2019-02-19 15:09 ` [alsa-devel] " xiang xiao
2019-02-19 15:09 ` xiang xiao
2019-02-19 15:55 ` [alsa-devel] " Pierre-Louis Bossart
2019-02-19 15:55 ` Pierre-Louis Bossart
2019-02-21 4:39 ` [alsa-devel] " Vinod Koul
2019-02-21 4:39 ` Vinod Koul
2019-02-21 10:42 ` [alsa-devel] " Arnaud Pouliquen
2019-02-21 10:42 ` Arnaud Pouliquen
2019-02-21 11:28 ` [alsa-devel] " Mark Brown
2019-02-21 11:28 ` Mark Brown
2019-02-21 23:49 ` [alsa-devel] " Pierre-Louis Bossart
2019-02-21 23:49 ` Pierre-Louis Bossart
2019-02-21 15:27 ` [alsa-devel] " Pierre-Louis Bossart
2019-02-21 15:27 ` Pierre-Louis Bossart
2019-02-22 8:32 ` [alsa-devel] " xiang xiao
2019-02-22 8:32 ` xiang xiao
2019-02-22 11:15 ` [alsa-devel] " Keyon Jie
2019-02-22 11:15 ` Keyon Jie
2019-02-22 18:21 ` [alsa-devel] " xiang xiao
2019-02-22 18:21 ` xiang xiao
2019-02-25 3:05 ` [Sound-open-firmware] [alsa-devel] [v4, 00/14] " Keyon Jie
2019-02-25 3:05 ` [Sound-open-firmware] " Keyon Jie
2019-02-22 14:48 ` [Sound-open-firmware] [alsa-devel] " Pierre-Louis Bossart
2019-02-22 14:48 ` [Sound-open-firmware] " Pierre-Louis Bossart
2019-02-22 18:41 ` [Sound-open-firmware] [alsa-devel] " xiang xiao
2019-02-22 18:41 ` [Sound-open-firmware] " xiang xiao
2019-02-22 21:52 ` [alsa-devel] " Pierre-Louis Bossart
2019-02-22 21:52 ` Pierre-Louis Bossart
2019-02-23 16:42 ` [alsa-devel] " xiang xiao
2019-02-23 16:42 ` xiang xiao
2019-02-25 10:16 ` [Sound-open-firmware] [alsa-devel] " Srinivas Kandagatla
2019-02-25 10:16 ` [Sound-open-firmware] " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h36oqze1q.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=vkoul@kernel.org \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.