From: Takashi Iwai <tiwai@suse.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jonas Witschel <diabonas@gmx.de>, alsa-devel@alsa-project.org
Subject: Re: [alsa-devel] [PATCH] Revert "ALSA: hda: Flush interrupts on disabling"
Date: Mon, 28 Oct 2019 09:24:00 +0100 [thread overview]
Message-ID: <s5h8sp5mg67.wl-tiwai@suse.de> (raw)
In-Reply-To: <157225086749.26808.5121664839140883561@skylake-alporthouse-com>
On Mon, 28 Oct 2019 09:21:07 +0100,
Chris Wilson wrote:
>
> Quoting Takashi Iwai (2019-10-28 08:10:56)
> > This reverts commit caa8422d01e983782548648e125fd617cadcec3f.
> >
> > It turned out that this commit caused a regression at shutdown /
> > reboot, as the synchronize_irq() calls seems blocking the whole
> > shutdown. Also another part of the change about shuffling the call
> > order looks suspicious; the azx_stop_chip() call disables the CORB /
> > RIRB while the others may still need the CORB/RIRB update.
> >
> > Since the original commit itself was a cargo-fix, let's revert the
> > whole patch.
>
> You will want to include a link to the bug you may be reintroducing so
> you have that information for easy reference later.
Actually I forgot to put the Fixes tag where usually you can track the
original issue from there. Will fix it. I don't mind to put yet
another bug link tag, though.
> Also do you know if you fixed the bug in any other way, because our CI
> hasn't reported that GPF since the patch landed.
Well, let's see whether the GPF reappears with the revert at first.
It might be another fix that covered.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-28 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 8:10 [alsa-devel] [PATCH] Revert "ALSA: hda: Flush interrupts on disabling" Takashi Iwai
2019-10-28 8:21 ` Chris Wilson
2019-10-28 8:24 ` Takashi Iwai [this message]
2019-10-28 11:09 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8sp5mg67.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=chris@chris-wilson.co.uk \
--cc=diabonas@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.