From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: cezary.rojewski@intel.com, patch@alsa-project.org,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
broonie@kernel.org,
Pawel Harlozinski <pawel.harlozinski@linux.intel.com>
Subject: Re: [alsa-devel] [RFC PATCH 2/3] ALSA:core: Add rate 24kHz
Date: Thu, 05 Sep 2019 15:16:28 +0200 [thread overview]
Message-ID: <s5h8sr2rihf.wl-tiwai@suse.de> (raw)
In-Reply-To: <9b997691-a609-e7b5-94a6-d42e26dfa080@linux.intel.com>
On Thu, 05 Sep 2019 15:11:43 +0200,
Pierre-Louis Bossart wrote:
>
> On 9/5/19 12:48 AM, Takashi Iwai wrote:
> > On Thu, 05 Sep 2019 07:33:00 +0200,
> > Pawel Harlozinski wrote:
> >>
> >> Adds SNDRV_PCM_RATE_24000 at the bottom to keep backward compability
> >> with alsa library.
> >>
> >> Signed-off-by: Pawel Harlozinski <pawel.harlozinski@linux.intel.com>
> >
> > No. Such a fancy rate has to be handled inside the driver locally
> > instead of adding to the common rate.
>
> It's not that crazy, this is supported in the HDaudio spec:
>
> Sample Base Rate Divisor (DIV):
> 000 = Divide by 1 (48 kHz, 44.1 kHz)
> 001 = Divide by 2 (24 kHz, 22.05 kHz)
>
> I am not sure why 22.05 made the cut and not 24 kHz, they are both
> derived from common clocks with the same divider... Same for 11.025
> and 12...
I'm not against supporting it. It'd be fine if it were the changes
that are applied only to HD-audio driver side. What I'm against is to
change the ALSA PCM core. It's not necessarily done there at all.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-05 13:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 5:32 [alsa-devel] [RFC PATCH 1/3] ALSA:hda: Simplify and clear calculating SDxFMT Pawel Harlozinski
2019-09-05 5:33 ` [alsa-devel] [RFC PATCH 2/3] ALSA:core: Add rate 24kHz Pawel Harlozinski
2019-09-05 5:48 ` Takashi Iwai
2019-09-05 13:11 ` Pierre-Louis Bossart
2019-09-05 13:16 ` Takashi Iwai [this message]
2019-09-05 14:00 ` Pierre-Louis Bossart
2019-09-05 14:09 ` Takashi Iwai
2019-09-05 5:33 ` [alsa-devel] [RFC PATCH 3/3] ALSA:hda: Add rates 24kHz, 64kHz Pawel Harlozinski
2019-09-05 5:33 ` Pawel Harlozinski
2019-09-05 5:47 ` [alsa-devel] [RFC PATCH 1/3] ALSA:hda: Simplify and clear calculating SDxFMT Takashi Iwai
2019-09-06 13:41 ` Harlozinski, Pawel
2019-09-06 14:16 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h8sr2rihf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=patch@alsa-project.org \
--cc=pawel.harlozinski@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.