All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Dmitry Panchenko | d-Systems <dmitry@d-systems.ee>
Cc: alsa-devel@alsa-project.org, alexander@tsoy.me
Subject: Re: ALSA: usb-audio: Add Pioneer DJ DJM-900NXS2 support
Date: Mon, 01 Jun 2020 20:44:31 +0200	[thread overview]
Message-ID: <s5hd06iiq28.wl-tiwai@suse.de> (raw)
In-Reply-To: <48ab19ff-3303-9bf8-ed0e-bcb31d8537eb@d-systems.ee>

On Mon, 01 Jun 2020 12:22:24 +0200,
Dmitry Panchenko | d-Systems wrote:
> 
> Pioneer DJ DJM-900NXS2 is a widely used DJ mixer with 2 audio USB
> interfaces. Both have a MIDI controller, 10 playback and 12 capture
> channels. Audio endpoints are vendor-specific and 3 files need to be
> patched. All playback and capture channels work fine with all supported
> sample rates (44.1k, 48k, 96k). Patches are attached.
> 
> Signed-off-by: Dmitry Panchenko <dmitry@d-systems.ee>

Applied now.

But, at the next time, please keep the following in mind:
- Make a patch applicable with -p1 option, i.e. diff between
  a/sound/usb and b/sound/usb

- Align both From and Signed-off-by name and address consistently

I fixed manually at this time, so no resubmission needed.


thanks,

Takashi

      reply	other threads:[~2020-06-01 18:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  9:56 Pioneer DJ DJM-900NXS2 support patches Dmitry Panchenko | d-Systems
2020-04-30 17:18 ` Takashi Iwai
2020-04-30 17:40 ` Alexander Tsoy
2020-05-01 12:14 ` Dmitry Panchenko | d-Systems
2020-06-01 10:22   ` ALSA: usb-audio: Add Pioneer DJ DJM-900NXS2 support Dmitry Panchenko | d-Systems
2020-06-01 18:44     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd06iiq28.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alexander@tsoy.me \
    --cc=alsa-devel@alsa-project.org \
    --cc=dmitry@d-systems.ee \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.