From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org,
Romain Perier <romain.perier@gmail.com>,
timur@kernel.org, Xiubo.Lee@gmail.com, clemens@ladisch.de,
tiwai@suse.com, Allen Pais <allen.lkml@gmail.com>,
nicoleotsuka@gmail.com, broonie@kernel.org
Subject: Re: [PATCH v2 02/10] ALSA: firewire: convert tasklets to use new tasklet_setup() API
Date: Wed, 02 Sep 2020 11:14:37 +0200 [thread overview]
Message-ID: <s5hft80bkw2.wl-tiwai@suse.de> (raw)
In-Reply-To: <20200902084443.GA791585@workstation>
On Wed, 02 Sep 2020 10:44:43 +0200,
Takashi Sakamoto wrote:
>
> To Iwai-san,
>
> I'm review your patch in 'test/kill-tasklet' branch in sound.git[1].
> Although I agree with the direction to obsolete tasklet usage with
> workqueue, 'in_interrupt()' helper function is used in two lines in
> 'sound/firewire/amdtp-stream.c' since it's convenient to distinguish
> running context (any softirq or user task). We need enough care of
> the cases about which below two patches mention:
>
> * 1dba9db0eaa6 ('ALSA: firewire-lib: permit to flush queued packets
> only in process context for better PCM period granularity')
> * 4a9bfafc64f4 ('ALSA: firewire-lib: Fix stall of process context
> at packet error)
>
> As long as I know, we have no helper function to distinguish workqueue
> task from user task. The simple replacement is not good way in the case.
Thanks for pointing this out, it was indeed an overlook.
We can use current_work() to check whether the current task comes from
the dedicated work or not, e.g.
if (current_work() == &myobject->some_work)
its_from_my_work();
Takashi
next prev parent reply other threads:[~2020-09-02 9:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 4:02 [PATCH v2 00/10] ALSA: convert tasklets to use new Allen Pais
2020-09-02 4:02 ` [PATCH v2 01/10] ALSA: core: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-02 4:02 ` [PATCH v2 02/10] ALSA: firewire: " Allen Pais
2020-09-02 8:44 ` Takashi Sakamoto
2020-09-02 9:14 ` Takashi Iwai [this message]
2020-09-02 4:02 ` [PATCH v2 03/10] ALSA: pci/asihpi: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 04/10] ALSA: riptide: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 05/10] ALSA: hdsp: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 06/10] ASoc: fsl_esai: " Allen Pais
2020-09-02 10:08 ` Mark Brown
2020-09-02 4:02 ` [PATCH v2 07/10] ASoC: siu: " Allen Pais
2020-09-02 10:10 ` Mark Brown
2020-09-02 4:02 ` [PATCH v2 08/10] ASoC: txx9: " Allen Pais
2020-09-02 10:10 ` Mark Brown
2020-09-02 4:02 ` [PATCH v2 09/10] ALSA: usb-audio: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 10/10] ALSA: ua101: " Allen Pais
2020-09-02 11:57 ` [PATCH v2 00/10] ALSA: convert tasklets to use new Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hft80bkw2.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Xiubo.Lee@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=clemens@ladisch.de \
--cc=nicoleotsuka@gmail.com \
--cc=o-takashi@sakamocchi.jp \
--cc=romain.perier@gmail.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.