From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de,
ffado-devel@lists.sf.net
Subject: Re: [PATCH] ALSA: firewire: arrange common PCM info/constraints for AMDTP engine applications
Date: Thu, 08 Jun 2017 09:16:40 +0200 [thread overview]
Message-ID: <s5hk24n2bl3.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170608001103.28870-1-o-takashi@sakamocchi.jp>
On Thu, 08 Jun 2017 02:11:03 +0200,
Takashi Sakamoto wrote:
>
> In ALSA firewire stack, 8 drivers uses IEC 61883-1/6 engine for data
> transmission. They have common PCM info/constraints and duplicated codes.
>
> This commit unifies the codes into fireiwre-lib.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> sound/firewire/amdtp-stream.c | 19 +++++++++++++++++
> sound/firewire/bebob/bebob_pcm.c | 21 -------------------
> sound/firewire/dice/dice-pcm.c | 20 ------------------
> sound/firewire/digi00x/digi00x-pcm.c | 33 ++++++++++--------------------
> sound/firewire/fireface/ff-pcm.c | 21 -------------------
> sound/firewire/fireworks/fireworks_pcm.c | 21 -------------------
> sound/firewire/motu/motu-pcm.c | 20 ------------------
> sound/firewire/oxfw/oxfw-pcm.c | 20 ------------------
> sound/firewire/tascam/tascam-pcm.c | 35 ++++++--------------------------
> 9 files changed, 36 insertions(+), 174 deletions(-)
Lovely, lots of code reduction.
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2017-06-08 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 0:11 [PATCH] ALSA: firewire: arrange common PCM info/constraints for AMDTP engine applications Takashi Sakamoto
2017-06-08 7:16 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hk24n2bl3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=ffado-devel@lists.sf.net \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.