All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
	lgirdwood@gmail.com, dri-devel@lists.freedesktop.org,
	broonie@kernel.org, Daniel Vetter <daniel.vetter@intel.com>,
	Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v2 03/14] ASoC: hdac_hdmi - Use list to add pins and converters
Date: Thu, 03 Dec 2015 16:44:55 +0100	[thread overview]
Message-ID: <s5hlh9bsfig.wl-tiwai@suse.de> (raw)
In-Reply-To: <1449176942-3441-3-git-send-email-subhransu.s.prusty@intel.com>

On Thu, 03 Dec 2015 22:08:51 +0100,
Subhransu S. Prusty wrote:
>  static int hdac_hdmi_dev_remove(struct hdac_ext_device *edev)
>  {
> +	struct hdac_hdmi_priv *hdmi = edev->private_data;
> +	struct hdac_hdmi_pin *pin;
> +	struct hdac_hdmi_cvt *cvt;
> +
>  	snd_soc_unregister_codec(&edev->hdac.dev);
>  
> +	list_for_each_entry(cvt, &hdmi->cvt_list, head) {
> +		list_del(&cvt->head);
> +		kfree(cvt);
> +	}
> +
> +	list_for_each_entry(pin, &hdmi->pin_list, head) {
> +		list_del(&pin->head);
> +		kfree(pin);
> +	}

These must be list_for_each_entry_safe().


Takashi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-12-03 15:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-03 21:02 [PATCH v2 00/14] ASoC: hdac_hdmi: Add DP & notification support Subhransu S. Prusty
2015-12-03 21:08 ` [PATCH v2 01/14] ASoC: hdac_hdmi: Fix to check num nodes correctly Subhransu S. Prusty
2015-12-03 21:08   ` [PATCH v2 02/14] ASoC: hdac_hdmi: Fix to warn instead of err for no connected nids Subhransu S. Prusty
2015-12-03 21:08   ` [PATCH v2 03/14] ASoC: hdac_hdmi - Use list to add pins and converters Subhransu S. Prusty
2015-12-03 15:44     ` Takashi Iwai [this message]
2015-12-04 10:16       ` Subhransu S. Prusty
2015-12-03 21:08   ` [PATCH v2 04/14] ASoC: hdac_hdmi: Add hotplug notification and read eld Subhransu S. Prusty
2015-12-03 15:51     ` Takashi Iwai
2015-12-04 10:16       ` Subhransu S. Prusty
2015-12-03 21:08   ` [PATCH v2 05/14] ALSA: pcm: Add DRM helper to set constraint for format Subhransu S. Prusty
2015-12-03 15:57     ` Takashi Iwai
2015-12-04 11:08       ` Subhransu S. Prusty
2015-12-04  5:59         ` Takashi Iwai
2015-12-05 11:27           ` Subhransu S. Prusty
2015-12-05  8:12             ` Takashi Iwai
2015-12-05 14:05               ` Subhransu S. Prusty
2015-12-05  9:05                 ` Takashi Iwai
2015-12-03 21:08   ` [PATCH v2 06/14] ASoC: hdac_hdmi: Apply constraints based on ELD Subhransu S. Prusty
2015-12-03 21:08   ` [PATCH v2 07/14] ASoC: hdac_hdmi: Enable DP1.2 and all converters/pins Subhransu S. Prusty
2016-02-15 20:58     ` Applied "ASoC: hdac_hdmi: Enable DP1.2 and all converters/pins" to the asoc tree Mark Brown
2015-12-03 21:08   ` [PATCH v2 08/14] ASoC: hdac_hdmi - create dais based on number of streams Subhransu S. Prusty
2015-12-03 16:13     ` Takashi Iwai
2015-12-03 21:08   ` [PATCH v2 09/14] ASoC: hdac_hdmi: Create widget/route based on nodes enumerated Subhransu S. Prusty
2015-12-03 21:08   ` [PATCH v2 10/14] ASoC: hdac_hdmi: Assign pin for stream based on dapm connection Subhransu S. Prusty
2015-12-03 21:08   ` [PATCH v2 11/14] drm/edid: Add API to help find connection type Subhransu S. Prusty
2015-12-03 16:16     ` Takashi Iwai
2015-12-04 10:30       ` Subhransu S. Prusty
2015-12-03 21:09   ` [PATCH v2 12/14] ASoC: hdac_hdmi: Add infoframe support for dp audio Subhransu S. Prusty
2015-12-03 17:13     ` Daniel Stone
2015-12-04 10:32       ` Subhransu S. Prusty
2015-12-03 21:09   ` [PATCH v2 13/14] ASoC: hdac_hdmi: Add codec suspend/resume handler Subhransu S. Prusty
2015-12-03 21:09   ` [PATCH v2 14/14] ASoC: hdac_hdmi: Fix to keep display active while enumerating codec Subhransu S. Prusty
2016-01-05 23:07   ` Applied "ASoC: hdac_hdmi: Fix to check num nodes correctly" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlh9bsfig.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches.audio@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.