Re: [PATCH 00/48] Rewrite kernel messages with standard printk helpers

From: Takashi Iwai <tiwai@suse.de>
To: Raymond Yau <superquad.vortex2@gmail.com>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 00/48] Rewrite kernel messages with standard printk helpers
Date: Thu, 27 Feb 2014 14:18:49 +0100	[thread overview]
Message-ID: <s5hlhwwwv5y.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAN8ccibaCvPrWqPAnCjmpCUL5UOQ0Mnqp0YD1NKAkOam8195SQ@mail.gmail.com>

At Thu, 27 Feb 2014 20:15:39 +0800,
Raymond Yau wrote:
> 
> > > > Hi,
> > > > > >
> > > > > > this is another long series of patches for trivial cleanups.
> > > > > > This time, they replace the printk and snd_print*() calls in ALSA
> > PCI
> > > > > > and USB drivers with dev_err() and co.  This will give nicer and
> > more
> > > > > > consistent outputs.
> > > > > >
> > > > > > The only drawback by these replacements is that alsa-info.sh won't
> > be
> > > > > > able to catch the dmesg lines because it doesn't contain any longer
> > > > > > the word "ALSA", but only show the module name like "snd_intel8x0".
> > > > > >
> > > > > > I'm going to fix alsa-info.sh on git soon later, but if you guys
> > think
> > > > > > "oh no it's disaster!", let me know.  We need to reconsider a
> > better
> > > > > > way to put the known markers (like explicitly putting "ALSA" at the
> > > > > > beginning.)
> > > > > >
> > > > > >
> > > > > seem missing au88x0
> > > >
> > > > Yes, because some driver codes are horrible to work on.
> > > > Patches are welcome.
> >
> 
> do sound-unstable.git test/snd-device need alsa-driver-build-unstable.git ?

No.

> > > >
> > > > > can the driver build as modules in kernel 3.11 (ubuntu 13.10) ?
> > > >
> > > > The dev_err() and co exist since ages ago, so it shouldn't be a
> > > > problem.  These patches, however, need the previous change of
> > > > snd_card_new() to make the device pointer available in time.
> > > >
> > > > No idea about Ubuntu.
> > > >
> > > >
> > > it seem usb-audio failed to build as module since last year
> > >
> > >
> > https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=80ab8eae70e51d578ebbeb228e0f7a562471b8b7
> >
> > Ah, so you meant alsa-driver tree.  It's unmaintained so far due to
> > the lack of time.  I really consider dropping it.
> >
> >
> 
> emu10k1_main.c is patched but snd-emu10k1.ko is not built and there is no
> warning message about ZONE_DMA is not available

Strange, it builds fine with my 3.11 kernel.

Takashi