Re: [PATCH 1/6] leds: trigger: Introduce audio mute LED trigger

From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "ALSA Development Mailing List" <alsa-devel@alsa-project.org>,
	"Ayman Bagabas" <ayman.bagabas@gmail.com>,
	"Platform Driver" <platform-driver-x86@vger.kernel.org>,
	"Hui Wang" <hui.wang@canonical.com>,
	ibm-acpi-devel@lists.sourceforge.net,
	"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
	"Pavel Machek" <pavel@ucw.cz>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Linux LED Subsystem" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 1/6] leds: trigger: Introduce audio mute LED trigger
Date: Tue, 27 Nov 2018 12:04:37 +0100	[thread overview]
Message-ID: <s5htvk2ye62.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAHp75VcLuxBP2SrvN-B698BJ8=SGqPat-s=2k9cV+ObcoE8kww@mail.gmail.com>

On Mon, 26 Nov 2018 23:58:36 +0100,
Andy Shevchenko wrote:
> 
> On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > This patch adds a new LED trigger for coupling the audio mixer change
> > with the LED on laptops or other devices.  Currently there are two
> > trigger types, "audio-mute" and "audio-micmute".
> >
> > The audio driver triggers the LED brightness change via
> > ledtrig_audio_set() call with the proper type (either mute or
> > mic-mute).  OTOH, the consumers may call ledtrig_audio_get() for the
> > initial brightness value that may have been set by the audio driver
> > beforehand.
> >
> > This new stuff will be used by HD-audio codec driver and some platform
> > drivers (thinkpad_acpi and dell-laptop, also upcoming huawei-wmi).
> 
> > +#include <linux/module.h>
> 
> > +#include <linux/init.h>
> 
> Only on of above is needed, I think you meant module.h.

Right, dropped init.h inclusion.  Also sorted now.

thanks,

Takashi