From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: mengdong.lin@intel.com, alsa-devel@alsa-project.org,
liam.r.girdwood@intel.com
Subject: Re: [PATCH v2 09/10] ASoC: topology: Change stream formats to bitwise flag
Date: Sat, 15 Aug 2015 18:52:18 +0200 [thread overview]
Message-ID: <s5hvbcgxznh.wl-tiwai@suse.de> (raw)
In-Reply-To: <20150815145904.GE10748@sirena.org.uk>
On Sat, 15 Aug 2015 16:59:04 +0200,
Mark Brown wrote:
>
> On Sat, Aug 15, 2015 at 09:37:34AM +0200, Takashi Iwai wrote:
>
> > We can make the topology stuff disabled in Makefile (and the only call
> > in soc-core.c) instead of the whole revert. This will be the minimal
> > impact and safe enough.
>
> Yes, though it does leave the UAPI files there for people to look at
> which is a big part of the risk since they end up getting shipped
> separately to the kernel binary.
True, if we want really 120% safety...
> Might be sufficient, though - we could
> just put some #errors in the headers to catch potential users. Or
> perhaps we're OK with the ABI as it stands.
Yeah, #error or a big fat comment should suffice, I suppose.
> > BTW, I wonder why there is no Kconfig for topology stuff. If we had
> > it, it would have been easy to disable.
>
> It's probably worth adding that anyway - I know Intel at least are keen
> on having the capability to minimise memory usage!
Right, I had it in my mind, too.
Takashi
next prev parent reply other threads:[~2015-08-15 16:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 14:45 [PATCH v2 00/10] ASoC: support adding PCM dynamically from topology mengdong.lin
2015-08-10 14:45 ` [PATCH v2 01/10] ASoC: Change the PCM runtime array to a list mengdong.lin
2015-08-14 20:02 ` Mark Brown
2015-08-17 6:28 ` Lin, Mengdong
2015-08-10 14:46 ` [PATCH v2 02/10] ASoC: Define soc_init_dai_link() to wrap link intialization mengdong.lin
2015-08-10 14:47 ` [PATCH v2 03/10] ASoC: Change 2nd argument of soc_bind_dai_link() to DAI link pointer mengdong.lin
2015-08-10 14:47 ` [PATCH v2 04/10] ASoC: Implement DAI links in a list mengdong.lin
2015-08-10 14:47 ` [PATCH v2 05/10] ASoC: Add support for dummy DAI links and PCM runtimes mengdong.lin
2015-08-14 20:22 ` Mark Brown
2015-08-17 10:01 ` Lin, Mengdong
2015-08-17 18:39 ` Mark Brown
2015-08-10 14:48 ` [PATCH v2 06/10] ASoC: Bind new DAI links after probing components mengdong.lin
2015-08-10 14:48 ` [PATCH v2 07/10] ASoC: Support adding a DAI dynamically mengdong.lin
2015-08-10 14:48 ` [PATCH v2 08/10] ASoC: topology: Change pass number of DAI smaller than graph mengdong.lin
2015-08-10 14:48 ` [PATCH v2 09/10] ASoC: topology: Change stream formats to bitwise flag mengdong.lin
2015-08-14 20:34 ` Mark Brown
2015-08-15 7:37 ` Takashi Iwai
2015-08-15 13:49 ` Lin, Mengdong
2015-08-15 14:45 ` Takashi Iwai
2015-08-15 15:25 ` Lin, Mengdong
2015-08-15 16:50 ` Takashi Iwai
2015-08-15 16:51 ` Mark Brown
2015-08-17 10:05 ` Lin, Mengdong
2015-08-15 15:14 ` Mark Brown
2015-08-15 14:59 ` Mark Brown
2015-08-15 16:52 ` Takashi Iwai [this message]
2015-08-10 14:48 ` [PATCH v2 10/10] ASOC: topology: Add PCM DAIs dynamically when loading them mengdong.lin
2015-08-15 7:56 ` [PATCH v2 00/10] ASoC: support adding PCM dynamically from topology Lars-Peter Clausen
2015-08-15 15:50 ` Mark Brown
2015-08-17 6:13 ` Lin, Mengdong
2015-08-17 10:39 ` Liam Girdwood
2015-08-17 20:05 ` Mark Brown
2015-08-18 5:17 ` Lin, Mengdong
2015-08-18 5:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hvbcgxznh.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@intel.com \
--cc=mengdong.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.