From: Chris PeBenito <pebenito@ieee.org>
To: Luis Ressel <aranea@aixah.de>, selinux-refpolicy@vger.kernel.org
Subject: Re: init_daemon_domain vs init_spec_daemon_domain
Date: Fri, 9 Nov 2018 19:22:22 -0500 [thread overview]
Message-ID: <0664b97f-dd55-51a3-41ef-c3f1f69bc7a9@ieee.org> (raw)
In-Reply-To: <20181108001419.0d06cd9b@vega.skynet.aixah.de>
On 11/07/2018 06:14 PM, Luis Ressel wrote:
> Hello *,
>
> I've noticed the init_daemon_domain and init_spec_daemon_domain
> interfaces contain quite a bit of duplicated code. As can be seen from
> the patch I just [two weeks ago, but this mail unfortunately didn't go
> out back then due to a problem on my end] posted, this has already
> caused bugs.
>
> Ideally, init_daemon_domain should just call init_spec_daemon_domain
> and only add a typetransition statement on top of it. However, this is
I'm inclined to accept a patch that will make this so, regardless of the
below concerns, since there are no usages in refpolicy.
> currently not possible because those two interfaces differ in some
> aspects:
>
> * i_d_d grants the daemon nscd_use() permissions, while i_s_d_d
> doesn't. This is most likely an oversight too.
>
> * i_d_d permits transitions from initrc_t to the daemon domain, while
> i_s_d_d permits transitions from init_t. This is thoroughly odd. My
> expectation was that i_s_d_d would allow transitions from initrc_t
> too, and as far as I understand the situation, transitions directly
> from init_t do a daemon domain only happen with systemd.
>
> * The ifdef(init_systemd) blocks of the two interfaces are very
> different. Could someone familiar with the systemd policy please
> comment on this?
>
> * i_s_d_d obviously grants init_t (and initrc_t if that is added in the
> future) self:process setexec permissions, while i_d_d doesn't. This
> makes sense, of course, but if we can fix the three other differences
> I already mentioned, I don't believe this difference alone should
> block my proposed change.
>
> Thanks,
> Luis
>
--
Chris PeBenito
prev parent reply other threads:[~2018-11-10 0:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 23:14 init_daemon_domain vs init_spec_daemon_domain Luis Ressel
2018-11-10 0:22 ` Chris PeBenito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0664b97f-dd55-51a3-41ef-c3f1f69bc7a9@ieee.org \
--to=pebenito@ieee.org \
--cc=aranea@aixah.de \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).