SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
From: "Sugar, David" <dsugar@tresys.com>
To: "selinux-refpolicy@vger.kernel.org"  <selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH v3] audit daemon can halt system, allow this to happen.
Date: Thu, 30 Jan 2020 14:40:13 +0000
Message-ID: <197e51f7-4b86-2758-11c0-d38f426d8785@tresys.com> (raw)
In-Reply-To: <20200122123529.691385-1-dsugar@tresys.com>


Can this get merged?  I have not seen any comments.
Would you prefer that I use a github pull request?

On 1/22/20 7:35 AM, Sugar, David wrote:
> auditd can halt the system for several reasons based on configuration.
> These mostly revovle around audit partition full issues.  I am seeing
> the following denials when attempting to halt the system.
> 
> Jan 12 03:38:48 localhost audispd: node=localhost type=USER_AVC msg=audit(1578800328.122:1943): pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='avc:  denied  { start } for auid=n/a uid=0 gid=0 path="/usr/lib/systemd/system/poweroff.target" cmdline="/sbin/init 0" scontext=system_u:system_r:auditd_t:s0 tcontext=system_u:object_r:power_unit_t:s0 tclass=service exe="/usr/lib/systemd/systemd" sauid=0 hostname=? addr=? terminal=?'
> Jan 12 03:38:48 localhost audispd: node=localhost type=USER_AVC msg=audit(1578800328.147:1944): pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='avc:  denied  { status } for auid=n/a uid=0 gid=0 path="/usr/lib/systemd/system/poweroff.target" cmdline="/sbin/init 0" scontext=system_u:system_r:auditd_t:s0 tcontext=system_u:object_r:power_unit_t:s0 tclass=service exe="/usr/lib/systemd/systemd" sauid=0 hostname=? addr=? terminal=?'
> Jan 12 04:44:54 localhost audispd: node=localhost type=AVC msg=audit(1578804294.103:1923): avc:  denied  { getattr } for  pid=6936 comm="systemctl" path="/run/systemd/system" dev="tmpfs" ino=45 scontext=system_u:system_r:auditd_t:s0 tcontext=system_u:object_r:systemd_unit_t:s0 tclass=dir permissive=1
> 
>   v2 - use optional rather than ifdef
>   v3 - fix order
>  > Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
>   policy/modules/system/logging.te |  6 ++++++
>   policy/modules/system/systemd.if | 20 ++++++++++++++++++++
>   2 files changed, 26 insertions(+)
> 
> diff --git a/policy/modules/system/logging.te b/policy/modules/system/logging.te
> index 4c11d061..bce6b4d8 100644
> --- a/policy/modules/system/logging.te
> +++ b/policy/modules/system/logging.te
> @@ -231,6 +231,12 @@ optional_policy(`
>   	seutil_sigchld_newrole(auditd_t)
>   ')
>   
> +optional_policy(`
> +	init_list_unit_dirs(auditd_t)
> +	systemd_start_power_units(auditd_t)
> +	systemd_status_power_units(auditd_t)
> +')
> +
>   optional_policy(`
>   	udev_read_db(auditd_t)
>   ')
> diff --git a/policy/modules/system/systemd.if b/policy/modules/system/systemd.if
> index a49b0f77..8e46f443 100644
> --- a/policy/modules/system/systemd.if
> +++ b/policy/modules/system/systemd.if
> @@ -791,6 +791,26 @@ interface(`systemd_start_power_units',`
>   	allow $1 power_unit_t:service start;
>   ')
>   
> +########################################
> +## <summary>
> +##	Get the system status information about power units
> +## </summary>
> +## <param name="domain">
> +##	<summary>
> +##	Domain allowed access.
> +##	</summary>
> +## </param>
> +#
> +interface(`systemd_status_power_units',`
> +	gen_require(`
> +		type power_unit_t;
> +		class service status;
> +	')
> +
> +	allow $1 power_unit_t:service status;
> +')
> +
> +
>   ########################################
>   ## <summary>
>   ##	Make the specified type usable for
> 

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 12:35 Sugar, David
2020-01-30 14:40 ` Sugar, David [this message]
2020-02-08 14:41 ` Chris PeBenito

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=197e51f7-4b86-2758-11c0-d38f426d8785@tresys.com \
    --to=dsugar@tresys.com \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org
	public-inbox-index selinux-refpolicy

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git