selinux-refpolicy.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jwcart2@tycho.nsa.gov (James Carter)
To: refpolicy@oss.tresys.com
Subject: [refpolicy] [PATCH 09/13] Fix interfaces that use an undeclared identifier
Date: Wed, 11 Apr 2018 14:56:39 -0400	[thread overview]
Message-ID: <20180411185639.23547-10-jwcart2@tycho.nsa.gov> (raw)
In-Reply-To: <20180411185639.23547-1-jwcart2@tycho.nsa.gov>

These interfaces are not being called in the policy.

dbus.if:dbus_send_all_session_bus()
  Use session_bus_type instead of dbus_session_bus_type.

rabbitmq.if:rabbitmq_domtrans()
  Use rabbitmq_epmd_t and rabbitmq_beam_t instead of rabbitmq_t
  and rabbitmq_epmd_exec_t and rabbitmq_beam_exec_t instead of
  rabbitmq_exec_t.

Signed-off-by: James Carter <jwcart2@tycho.nsa.gov>
---
 dbus.if     | 2 +-
 rabbitmq.if | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/dbus.if b/dbus.if
index 317d3d8..552034d 100644
--- a/dbus.if
+++ b/dbus.if
@@ -248,7 +248,7 @@ interface(`dbus_send_all_session_bus',`
 		class dbus send_msg;
 	')
 
-	allow $1 dbus_session_bus_type:dbus send_msg;
+	allow $1 session_bus_type:dbus send_msg;
 ')
 
 #######################################
diff --git a/rabbitmq.if b/rabbitmq.if
index 53efd0d..854cd36 100644
--- a/rabbitmq.if
+++ b/rabbitmq.if
@@ -12,11 +12,13 @@
 #
 interface(`rabbitmq_domtrans',`
 	gen_require(`
-		type rabbitmq_t, rabbitmq_exec_t;
+		type rabbitmq_epmd_t, rabbitmq_epmd_exec_t;
+		type rabbitmq_beam_t, rabbitmq_beam_exec_t;
 	')
 
 	corecmd_search_bin($1)
-	domtrans_pattern($1, rabbitmq_exec_t, rabbitmq_t)
+	domtrans_pattern($1, rabbitmq_epmd_exec_t, rabbitmq_epmd_t)
+	domtrans_pattern($1, rabbitmq_beam_exec_t, rabbitmq_beam_t)
 ')
 
 ########################################
-- 
2.13.6

  parent reply	other threads:[~2018-04-11 18:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 18:56 [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 01/13] Remove unnecessary semicolons James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 02/13] Mark unused parameter as unused James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 03/13] Add unused parameter and mark " James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 04/13] Remove use of undeclared attribute from portage.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 05/13] Move use of httpd_t from mojomojo.te to apache.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 06/13] Move use of sendmail_exec_t from sendmail.te to mta.te James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 07/13] Fix typos in identifier names James Carter
2018-04-11 18:56 ` [refpolicy] [PATCH 08/13] Remove undeclared identifiers from shorewall interfaces James Carter
2018-04-11 18:56 ` James Carter [this message]
2018-04-12 22:47 ` [refpolicy] [PATCH 00/13] Fix issues identified by spt_lint.lua to contrib Chris PeBenito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180411185639.23547-10-jwcart2@tycho.nsa.gov \
    --to=jwcart2@tycho.nsa.gov \
    --cc=refpolicy@oss.tresys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).