From: Petr Vorel <pvorel@suse.cz>
To: Chris PeBenito <pebenito@ieee.org>
Cc: selinux-refpolicy@vger.kernel.org, Dan Walsh <dwalsh@redhat.com>
Subject: Re: [PATCH 1/2] dnsmasq: Require log files to have .log suffix
Date: Mon, 12 Nov 2018 07:55:03 +0100 [thread overview]
Message-ID: <20181112065503.GA16658@dell5510> (raw)
In-Reply-To: <5137d6d9-5bdb-a21d-97c9-2e6c8a61c2a6@ieee.org>
Hi Chris,
...
> > +++ b/policy/modules/services/dnsmasq.fc
> > @@ -13,7 +13,7 @@
> > /var/lib/misc/dnsmasq\.leases -- gen_context(system_u:object_r:dnsmasq_lease_t,s0)
> > /var/lib/dnsmasq(/.*)? gen_context(system_u:object_r:dnsmasq_lease_t,s0)
> > -/var/log/dnsmasq.* -- gen_context(system_u:object_r:dnsmasq_var_log_t,s0)
> > +/var/log/dnsmasq(.*)?\.log -- gen_context(system_u:object_r:dnsmasq_var_log_t,s0)
> > /run/dnsmasq.* -- gen_context(system_u:object_r:dnsmasq_var_run_t,s0)
> > /run/libvirt/network(/.*)? gen_context(system_u:object_r:dnsmasq_var_run_t,s0)
> This would exclude rotated logs, e.g. something like dnsmasq.log.1 or
> dnsmasq.log.1.gz, which would be undesirable.
I didn't know dnsmasq need to open logs already handled by logrotate (I thought
logrotate creates these).
But I see apache has similar pattern.
I added the patern in v2:
/var/log/dnsmasq(.*)?\.log(\..+)
Kind regards,
Petr
prev parent reply other threads:[~2018-11-12 6:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 20:57 [PATCH 1/2] dnsmasq: Require log files to have .log suffix Petr Vorel
2018-11-07 20:57 ` [PATCH 2/2] dnsmasq: Add support for lxc-net, lxd-bridge, NetworkManager Petr Vorel
2018-11-10 0:30 ` Chris PeBenito
2018-11-10 0:25 ` [PATCH 1/2] dnsmasq: Require log files to have .log suffix Chris PeBenito
2018-11-12 6:55 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112065503.GA16658@dell5510 \
--to=pvorel@suse.cz \
--cc=dwalsh@redhat.com \
--cc=pebenito@ieee.org \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).