From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F53C43612 for ; Sun, 6 Jan 2019 18:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A0D320859 for ; Sun, 6 Jan 2019 18:31:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=tresys.onmicrosoft.com header.i=@tresys.onmicrosoft.com header.b="Zs97a+GY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726014AbfAFSbt (ORCPT ); Sun, 6 Jan 2019 13:31:49 -0500 Received: from mail-eopbgr690124.outbound.protection.outlook.com ([40.107.69.124]:39904 "EHLO NAM04-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726036AbfAFSbt (ORCPT ); Sun, 6 Jan 2019 13:31:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tresys.onmicrosoft.com; s=selector1-tresys-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UyFAs4vHoZqaUWzK74bfCW1q7M7aXElQEU9RBxYO8S0=; b=Zs97a+GY6tDNtnnVrxnkwFQfg4mGN21rktS0OL1VO0rnP5CPDRJxx4Ina5n/505DTMiLPkFJr1oQuuX9CAC4H7gEqcFkQedVJaINxItsEzF+AzX81KBX2VQOGeimIKi3cNcVeM+66tlp7UFQOlPb9eKD4Uxs2ZtTSBLev57vzH0= Received: from BN6PR15MB1507.namprd15.prod.outlook.com (10.172.151.147) by BN6PR15MB1236.namprd15.prod.outlook.com (10.172.206.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Sun, 6 Jan 2019 18:31:42 +0000 Received: from BN6PR15MB1507.namprd15.prod.outlook.com ([fe80::6d82:5bd:50b3:6a10]) by BN6PR15MB1507.namprd15.prod.outlook.com ([fe80::6d82:5bd:50b3:6a10%3]) with mapi id 15.20.1495.011; Sun, 6 Jan 2019 18:31:42 +0000 From: "Sugar, David" To: "selinux-refpolicy@vger.kernel.org" Subject: [PATCH 1/2 v3] Allow greeter to start dbus Thread-Topic: [PATCH 1/2 v3] Allow greeter to start dbus Thread-Index: AQHUpe4Rc7zreeWpUUqq/Cmtn6ddXQ== Date: Sun, 6 Jan 2019 18:31:42 +0000 Message-ID: <20190106182922.20344-1-dsugar@tresys.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [73.180.141.176] x-clientproxiedby: BN7PR06CA0004.namprd06.prod.outlook.com (2603:10b6:406:80::17) To BN6PR15MB1507.namprd15.prod.outlook.com (2603:10b6:404:c6::19) authentication-results: spf=none (sender IP is ) smtp.mailfrom=dsugar@tresys.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR15MB1236;6:n3wDXt2CuLTCR+sHsB8+zUBP1kIGzODlCaYch6p4ScRk0t54AMlNNeBeBqKwcPcvS/1jSnAniNDqsE3LIc16DGLhVk/XDFYaqM8uAX5h5LkvXFEoyA/3Vb5p5bum+21J4kAWeKBVjZz2d8tmbnptwGg/JwkAL33wyqasUQBT2tHexZ9PLctqmKlVlPhchlqROXRFg2HRIF9DAwKdzRcsk4fpCJAcjI4FG4KWX9v8mkVUgmQ4CwuMSu60ZbiNlIG33bSzqJ4oH8GjtYLu6CseO6BrcqXbYYaXufR0G30Zu4zy5kYqhhRR9VtNPE3UbHI2NR4fxBO1cgHZspsvoPhr699syuX3jB4I+951CThUYVy1Qp4rCTVzWGs47t4jTIqrCiVj6HlGMVAtOcV4c/TnF0/9OpKif2q2JAfQjQKew6v2uv/ndmB4xL6BQa1B9UM4xUU7XXXWHvf2RoCklnG3BA==;5:cKDwy7XZauJdQVVS2rmrJ7BvJ77S5hyKBIb5XUTuhLvcY9aBN9DZouPdfqDEIY342YjqPRl+A5W/fuudNcl7QbA5tLa5pQ9OK559sD2DxmhBo2qLOYFZliuJLEcaoVNnpUv64U4gC0Y10bXM5EunoD5y/PZgdBRHmCVg06ac7Vfnah6LSe1DcMs7C2jOoV1ngq3nKmftSyv/TLmOJQc6hQ==;7:b5/xbGwMWSTEqq7800ctQUReElE910ZAEDYDU8GlgbfYCYf3H3JGwcxRvmSp4IEA9DwTMqlrYXqOBDBoFtSi6CUOhsjLDLSjKMeySNYSZ6ahEF/OcxpTpXIy/1ruXn7MECDx8ZzB7YOJafxtOOvyyA== x-ms-office365-filtering-correlation-id: 4d976e7f-1206-4dd7-4308-08d67405343f x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(5600109)(711020)(2017052603328)(7153060)(7193020);SRVR:BN6PR15MB1236; x-ms-traffictypediagnostic: BN6PR15MB1236: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(10201501046)(3002001)(3231475)(944501520)(52105112)(93006095)(93001095)(6041310)(2016111802025)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6043046)(201708071742011)(7699051)(76991095);SRVR:BN6PR15MB1236;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1236; x-forefront-prvs: 09090B6B69 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(366004)(396003)(346002)(39830400003)(136003)(189003)(199004)(71200400001)(8936002)(71190400001)(66066001)(5640700003)(81166006)(53936002)(81156014)(14444005)(256004)(6916009)(25786009)(2501003)(1076003)(2906002)(8676002)(6436002)(5660300001)(6486002)(99286004)(316002)(6512007)(386003)(26005)(6506007)(2616005)(14454004)(186003)(102836004)(97736004)(508600001)(476003)(3846002)(6116002)(52116002)(86362001)(486006)(36756003)(305945005)(7736002)(106356001)(2351001)(68736007)(105586002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1236;H:BN6PR15MB1507.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: tresys.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Z5xIXyJBDuk69zbFf7Jb2XQ2KMqL9oHhU0mIM3518CgQQu5IP0hD+w8JkR+NU4gqIN42XJp71CuqNiHxR4r5sr+GdHQgUrvV8O4Y/fBmsKnpENEwNmZUt6s2CcBW7G2r1vlanDWAXJGAe4y6Elw1rFW8zJd2JlLa+3dXRGjN5RKnlRCHZsCHvpEyoYTgDpOBHCEsVPkByA15/0a2ZX2Y0cbMnpJUKv1FhbdNDaqvpcUSbtZ67gF0HKYm6iMBYy40JRUPBG3NzbJ+EEKmepN/f4rMebyzFjKZkG9ffnovvzZRevGVDl6a5ZL4Fkzv+3Fp spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: tresys.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d976e7f-1206-4dd7-4308-08d67405343f X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2019 18:31:42.4567 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a0d45667-6c07-4e88-868f-4ac9af95c7ed X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1236 Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org The display manager lightdm (and I think gdm) start a dbus binary. v3 - Updated based on feedback type=3DAVC msg=3Daudit(1544626796.378:201): avc: denied { execute } for = pid=3D9973 comm=3D"dbus-launch" name=3D"dbus-daemon" dev=3D"dm-1" ino=3D669= 5040 scontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=3Dsystem_u:= object_r:dbusd_exec_t:s0 tclass=3Dfile permissive=3D1 type=3DAVC msg=3Daudit(1544626796.378:201): avc: denied { read open } for= pid=3D9973 comm=3D"dbus-launch" path=3D"/usr/bin/dbus-daemon" dev=3D"dm-1= " ino=3D6695040 scontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext= =3Dsystem_u:object_r:dbusd_exec_t:s0 tclass=3Dfile permissive=3D1 type=3DAVC msg=3Daudit(1544626796.378:201): avc: denied { execute_no_tran= s } for pid=3D9973 comm=3D"dbus-launch" path=3D"/usr/bin/dbus-daemon" dev= =3D"dm-1" ino=3D6695040 scontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 t= context=3Dsystem_u:object_r:dbusd_exec_t:s0 tclass=3Dfile permissive=3D1 type=3DAVC msg=3Daudit(1544626796.378:201): avc: denied { map } for pid= =3D9973 comm=3D"dbus-daemon" path=3D"/usr/bin/dbus-daemon" dev=3D"dm-1" ino= =3D6695040 scontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=3Dsys= tem_u:object_r:dbusd_exec_t:s0 tclass=3Dfile permissive=3D1 type=3DAVC msg=3Daudit(1546551459.112:208): avc: denied { getcap } for pi= d=3D6275 comm=3D"dbus-daemon" scontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c= 1023 tcontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 tclass=3Dprocess per= missive=3D1 type=3DAVC msg=3Daudit(1546551459.116:209): avc: denied { read } for pid= =3D6275 comm=3D"dbus-daemon" name=3D"995" dev=3D"tmpfs" ino=3D35210 scontex= t=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=3Dsystem_u:object_r:sys= temd_logind_var_run_t:s0 tclass=3Dfile permissive=3D1 type=3DAVC msg=3Daudit(1546551459.116:209): avc: denied { open } for pid= =3D6275 comm=3D"dbus-daemon" path=3D"/run/systemd/users/995" dev=3D"tmpfs" = ino=3D35210 scontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=3Dsy= stem_u:object_r:systemd_logind_var_run_t:s0 tclass=3Dfile permissive=3D1 type=3DAVC msg=3Daudit(1546551459.116:210): avc: denied { getattr } for p= id=3D6275 comm=3D"dbus-daemon" path=3D"/run/systemd/users/995" dev=3D"tmpfs= " ino=3D35210 scontext=3Dsystem_u:system_r:xdm_t:s0-s0:c0.c1023 tcontext=3D= system_u:object_r:systemd_logind_var_run_t:s0 tclass=3Dfile permissive=3D1 Signed-off-by: Dave Sugar --- policy/modules/services/dbus.if | 19 +++++++++++++++++++ policy/modules/services/xserver.te | 7 +++++++ 2 files changed, 26 insertions(+) diff --git a/policy/modules/services/dbus.if b/policy/modules/services/dbus= .if index ef829e30..c815791e 100644 --- a/policy/modules/services/dbus.if +++ b/policy/modules/services/dbus.if @@ -17,6 +17,25 @@ interface(`dbus_stub',` ') ') =20 +######################################## +## +## Execute dbus in the caller domain. +## +## +## +## Domain allowed access. +## +## +# +interface(`dbus_exec',` + gen_require(` + type dbusd_exec_t; + ') + + corecmd_search_bin($1) + can_exec($1, dbusd_exec_t) +') + ######################################## ## ## Role access for dbus. diff --git a/policy/modules/services/xserver.te b/policy/modules/services/x= server.te index fa7ce88e..c7714d3e 100644 --- a/policy/modules/services/xserver.te +++ b/policy/modules/services/xserver.te @@ -566,12 +566,19 @@ optional_policy(` ') =20 optional_policy(` + allow xdm_t self:process getcap; + + dbus_exec(xdm_t) dbus_system_bus_client(xdm_t) dbus_connect_system_bus(xdm_t) =20 optional_policy(` accountsd_dbus_chat(xdm_t) ') + + optional_policy(` + systemd_read_logind_pids(xdm_t) + ') ') =20 optional_policy(` --=20 2.20.1