From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9656DC43387 for ; Tue, 8 Jan 2019 08:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C5042070B for ; Tue, 8 Jan 2019 08:55:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=coker.com.au header.i=@coker.com.au header.b="dSo1P3qJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727968AbfAHIzd (ORCPT ); Tue, 8 Jan 2019 03:55:33 -0500 Received: from smtp.sws.net.au ([46.4.88.250]:58750 "EHLO smtp.sws.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbfAHIzd (ORCPT ); Tue, 8 Jan 2019 03:55:33 -0500 Received: from xev.coker.com.au (localhost [127.0.0.1]) by smtp.sws.net.au (Postfix) with ESMTP id 34CF9EE4C for ; Tue, 8 Jan 2019 19:55:32 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coker.com.au; s=2008; t=1546937732; bh=b9qOHdz1vydmVoNt8u78QztZ9uN9lE+yk8cvHK3EtJ8=; l=1705; h=Date:From:To:Subject:From; b=dSo1P3qJJ+ETiByxy/Gq7EzU8clcJj56NYHxNtYqs/8k+2xMfIdxERRdZ9kDN0R7e uxEfvfIA0cKyAZw7AB0McHGuj/yEfK1EtAuFrbqzRsj3yhcWCbSQtNjaT3YNGc4j51 j1E9oU6kEsl6ehBc79xA634ZtHI0l97FtgB/i9lo= Received: by xev.coker.com.au (Postfix, from userid 1001) id A87F6C3E959; Tue, 8 Jan 2019 19:55:27 +1100 (AEDT) Date: Tue, 8 Jan 2019 19:55:27 +1100 From: Russell Coker To: selinux-refpolicy@vger.kernel.org Subject: [PATCH] logging Message-ID: <20190108085527.GA28836@xev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org Prosody and ntpd don't just need append access to their log files. Index: refpolicy-2.20180701/policy/modules/services/jabber.te =================================================================== --- refpolicy-2.20180701.orig/policy/modules/services/jabber.te +++ refpolicy-2.20180701/policy/modules/services/jabber.te @@ -80,9 +80,8 @@ allow jabberd_t self:netlink_route_socke manage_files_pattern(jabberd_t, jabberd_lock_t, jabberd_lock_t) allow jabberd_t jabberd_log_t:dir setattr_dir_perms; -append_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t) -create_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t) -setattr_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t) +manage_files_pattern(jabberd_t, jabberd_log_t, jabberd_log_t) + logging_log_filetrans(jabberd_t, jabberd_log_t, { file dir }) manage_files_pattern(jabberd_domain, jabberd_spool_t, jabberd_spool_t) Index: refpolicy-2.20180701/policy/modules/services/ntp.te =================================================================== --- refpolicy-2.20180701.orig/policy/modules/services/ntp.te +++ refpolicy-2.20180701/policy/modules/services/ntp.te @@ -73,9 +73,8 @@ read_lnk_files_pattern(ntpd_t, ntpd_key_ allow ntpd_t ntpd_lock_t:file rw_file_perms; allow ntpd_t ntpd_log_t:dir setattr_dir_perms; -append_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t) -create_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t) -setattr_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t) +manage_dirs_pattern(ntpd_t, ntpd_log_t, ntpd_log_t) +manage_files_pattern(ntpd_t, ntpd_log_t, ntpd_log_t) logging_log_filetrans(ntpd_t, ntpd_log_t, { file dir }) manage_files_pattern(ntpd_t, ntpd_pid_t, ntpd_pid_t)