SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
* [RFC] ssh: remove unconfined_shell_domtrans(sshd_t)
@ 2019-08-31 17:27 Dominick Grift
  2019-08-31 20:54 ` Chris PeBenito
  0 siblings, 1 reply; 4+ messages in thread
From: Dominick Grift @ 2019-08-31 17:27 UTC (permalink / raw)
  To: selinux-refpolicy; +Cc: Dominick Grift

This call allows sshd_t associated processes with run shell with an automatic domain transition to unconfined_t.
I was unable to make sense of the commit that added this:

https://github.com/SELinuxProject/refpolicy/commit/708aab13932bb8830a2d37850cc0a5c72a5d4df4

Debian's motd dynamic pam module makes sshd run a shell, we want this shell to run with sshd_t instead of unconfined_t

This patch will make the ssh_sysadm_login boolean apply to unconfined ssh logins.
To me this makes sense, as unconfined_t is targeted equivalent to the strict sysadm_t.
The boolean could however be renamed to the more generic ssh_priv_login name.

Signed-off-by: Dominick Grift <dac.override@gmail.com>
---
 policy/modules/services/ssh.te | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/policy/modules/services/ssh.te b/policy/modules/services/ssh.te
index 4e75b6e1..a99ad912 100644
--- a/policy/modules/services/ssh.te
+++ b/policy/modules/services/ssh.te
@@ -328,10 +328,6 @@ optional_policy(`
 	systemd_dbus_chat_logind(sshd_t)
 ')
 
-optional_policy(`
-	unconfined_shell_domtrans(sshd_t)
-')
-
 optional_policy(`
 	xserver_domtrans_xauth(sshd_t)
 	xserver_link_xdm_keys(sshd_t)
-- 
2.23.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-31 17:27 [RFC] ssh: remove unconfined_shell_domtrans(sshd_t) Dominick Grift
2019-08-31 20:54 ` Chris PeBenito
2019-09-01 11:19   ` Nicolas Iooss
2019-09-01 11:36     ` Dominick Grift

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org
	public-inbox-index selinux-refpolicy

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git