SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
From: Dominick Grift <dac.override@gmail.com>
To: selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] Remove shell automatic domain transitions to unconfined_t from various pam login programs
Date: Wed, 4 Sep 2019 09:25:10 +0200
Message-ID: <20190904072510.GB923044@brutus.lan> (raw)
In-Reply-To: <20190901124620.375409-1-dac.override@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2396 bytes --]

On Sun, Sep 01, 2019 at 02:46:20PM +0200, Dominick Grift wrote:
> I think these may have been adopted from the old Red Hat targeted policy (that model only had unconfined users)

Was this overlooked?

> 
> Some aspect to note:
> 
> 1. The ssh_sysadm_login boolean now applies to unconfined_t as well
> 2. remotelogin only allows unpriv logins
> 
> The rshd module also calls unconfined_shell_domtrans() but I ignored that one because that policy currently does not have support for manual transitions with pam_selinux.
> 
> Signed-off-by: Dominick Grift <dac.override@gmail.com>
> ---
>  policy/modules/services/remotelogin.te | 4 ----
>  policy/modules/services/ssh.te         | 4 ----
>  policy/modules/system/locallogin.te    | 4 ----
>  3 files changed, 12 deletions(-)
> 
> diff --git a/policy/modules/services/remotelogin.te b/policy/modules/services/remotelogin.te
> index bc2292e3..c7c9c564 100644
> --- a/policy/modules/services/remotelogin.te
> +++ b/policy/modules/services/remotelogin.te
> @@ -91,10 +91,6 @@ optional_policy(`
>  	telnet_use_ptys(remote_login_t)
>  ')
>  
> -optional_policy(`
> -	unconfined_shell_domtrans(remote_login_t)
> -')
> -
>  optional_policy(`
>  	usermanage_read_crack_db(remote_login_t)
>  ')
> diff --git a/policy/modules/services/ssh.te b/policy/modules/services/ssh.te
> index 4e75b6e1..a99ad912 100644
> --- a/policy/modules/services/ssh.te
> +++ b/policy/modules/services/ssh.te
> @@ -328,10 +328,6 @@ optional_policy(`
>  	systemd_dbus_chat_logind(sshd_t)
>  ')
>  
> -optional_policy(`
> -	unconfined_shell_domtrans(sshd_t)
> -')
> -
>  optional_policy(`
>  	xserver_domtrans_xauth(sshd_t)
>  	xserver_link_xdm_keys(sshd_t)
> diff --git a/policy/modules/system/locallogin.te b/policy/modules/system/locallogin.te
> index a56f3d1f..632d2542 100644
> --- a/policy/modules/system/locallogin.te
> +++ b/policy/modules/system/locallogin.te
> @@ -200,10 +200,6 @@ optional_policy(`
>  	systemd_write_inherited_logind_sessions_pipes(local_login_t)
>  ')
>  
> -optional_policy(`
> -	unconfined_shell_domtrans(local_login_t)
> -')
> -
>  optional_policy(`
>  	usermanage_read_crack_db(local_login_t)
>  ')
> -- 
> 2.23.0
> 

-- 
Key fingerprint = 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=get&search=0x3B6C5F1D2C7B6B02
Dominick Grift

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-01 12:46 Dominick Grift
2019-09-04  7:25 ` Dominick Grift [this message]
2019-09-07 20:27 ` Chris PeBenito

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190904072510.GB923044@brutus.lan \
    --to=dac.override@gmail.com \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org selinux-refpolicy@archiver.kernel.org
	public-inbox-index selinux-refpolicy


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/ public-inbox