From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91737C3A5A6 for ; Sat, 31 Aug 2019 20:54:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CD3322CE9 for ; Sat, 31 Aug 2019 20:54:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="L2RmXnwJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728512AbfHaUyj (ORCPT ); Sat, 31 Aug 2019 16:54:39 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:45891 "EHLO mail-qt1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727816AbfHaUyi (ORCPT ); Sat, 31 Aug 2019 16:54:38 -0400 Received: by mail-qt1-f172.google.com with SMTP id r15so5894095qtn.12 for ; Sat, 31 Aug 2019 13:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Gil9ijPJkwoDXyLpQwxmwbNA6UvF6mf/z0uunj0cA14=; b=L2RmXnwJcitLfGU8wmBp9h3Ov0UAnss2bK1q3Frl/srrmrV7DPaD9F/T0YaQXBK9eb 9LIb7B86X+WdpQnJ4Ta9HtS1vULa40SqMOhgSvfvfegld8ULf+dwifv5TPnpUwXKahig x5QW9NSbHd/O6gX479JCGY39SV9S4Pu2Y77hI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Gil9ijPJkwoDXyLpQwxmwbNA6UvF6mf/z0uunj0cA14=; b=JGwVhUP+B5kytfqJpMzQw+pOeDeCV2L27AtlPR+pTaSOv7DhxiF1i77ETLcRCJhwST bp53v2O1HGisyEZB5tMcbUY8go/uyESAIO/o/RFCBKWfNwPq7q9cFQGMLMvbJTNTQLwT ILbei0l71tVUAZPIcAIBaSZQ5npsIqLtVI74zwfTUPKqNWkocFIG7XX1nY+a2mz/vzkn McOn/v4uq/DdAYaiHvaHBwGZKjF1HUnVwjQXaXhO9JsAPyjAwbOhBIV7wKsuvDegaArQ MU3ei2K74E/1FbryZpCABLjxHLMO6f2epkXgCsLbhEq+8P06N5KlGSYGzHpNSSkeLjJj Wt7g== X-Gm-Message-State: APjAAAUTxIz/0FBceASaiQBwBzGpONuAFRzqVYisrIFmEVrjQ7PXAk0N YJSQQaHoFi0UjCGayKuFH6ztISOiv90= X-Google-Smtp-Source: APXvYqxdzLyCRT66w0tj+1UJw+fo2nmkmpHWkiSdbzKRDkiS42HwzGhfbkpk88k6Uw4OrHVJQptrzg== X-Received: by 2002:ac8:4542:: with SMTP id z2mr22055021qtn.265.1567284875747; Sat, 31 Aug 2019 13:54:35 -0700 (PDT) Received: from [192.168.1.190] (pool-108-15-23-247.bltmmd.fios.verizon.net. [108.15.23.247]) by smtp.gmail.com with ESMTPSA id f22sm4363349qkh.55.2019.08.31.13.54.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Aug 2019 13:54:35 -0700 (PDT) Subject: Re: [RFC] ssh: remove unconfined_shell_domtrans(sshd_t) To: Dominick Grift , selinux-refpolicy@vger.kernel.org References: <20190831172713.140005-1-dac.override@gmail.com> From: Chris PeBenito Message-ID: <21a95013-0147-63fa-77ab-471ef24b0eb8@ieee.org> Date: Sat, 31 Aug 2019 16:54:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190831172713.140005-1-dac.override@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On 8/31/19 1:27 PM, Dominick Grift wrote: > This call allows sshd_t associated processes with run shell with an automatic domain transition to unconfined_t. > I was unable to make sense of the commit that added this: > > https://github.com/SELinuxProject/refpolicy/commit/708aab13932bb8830a2d37850cc0a5c72a5d4df4 > > Debian's motd dynamic pam module makes sshd run a shell, we want this shell to run with sshd_t instead of unconfined_t > > This patch will make the ssh_sysadm_login boolean apply to unconfined ssh logins. > To me this makes sense, as unconfined_t is targeted equivalent to the strict sysadm_t. > The boolean could however be renamed to the more generic ssh_priv_login name. > > Signed-off-by: Dominick Grift > --- > policy/modules/services/ssh.te | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/policy/modules/services/ssh.te b/policy/modules/services/ssh.te > index 4e75b6e1..a99ad912 100644 > --- a/policy/modules/services/ssh.te > +++ b/policy/modules/services/ssh.te > @@ -328,10 +328,6 @@ optional_policy(` > systemd_dbus_chat_logind(sshd_t) > ') > > -optional_policy(` > - unconfined_shell_domtrans(sshd_t) > -') > - > optional_policy(` > xserver_domtrans_xauth(sshd_t) > xserver_link_xdm_keys(sshd_t) I don't have any objections to this. -- Chris PeBenito