From: "Sugar, David" <dsugar@tresys.com>
To: "selinux-refpolicy@vger.kernel.org" <selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH 2/2] pam_faillock creates files in /run/faillock
Date: Sat, 22 Dec 2018 02:58:41 +0000 [thread overview]
Message-ID: <2d2d6c7f-3084-d6f6-ce1b-42c9d9535969@tresys.com> (raw)
In-Reply-To: <20181221103416.GA4520@brutus.lan>
On 12/21/18 5:34 AM, Dominick Grift wrote:
> On Fri, Dec 21, 2018 at 01:41:25AM +0000, David Sugar wrote:
>> These are changes needed when pam_fallock created files in /run/faillock
>> (which is labeled faillog_t). sudo and xdm (and probably other domains)
>> will create files in this directory for successful and failed logins
>> attempts.
> The pam stuff has become a bit broken in my view.
>
> We use to use auth_use_pam() for these kinds of things but the interface was forgotten and not updated properly.
>
> So for example sudo does not even call auth_use_pam() and a lot of stuff was added directly to the login_pgm domain that should have been added to auth_use_pam() instead.
>
> My opinion is that this belongs in auth_use_pam()
Dominick,
I see those interfaces. It looks like xdm_t already uses
auth_login_pgm_domain(xdm_t). It also isn't really clear to me what the
difference is between auth_login_pgm_domain() and auth_use_pam(). I
will make updates moving my change into auth_use_pam() and also update
sudo_role_template() to use (I think) auth_login_pgm_domain ().
I will resubmit this patch,
--- snip ---
next prev parent reply other threads:[~2018-12-22 2:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 1:41 [PATCH 1/2] Allow greeter to start dbus and transition David Sugar
2018-12-21 1:41 ` [PATCH 2/2] pam_faillock creates files in /run/faillock David Sugar
2018-12-21 10:34 ` Dominick Grift
2018-12-22 2:58 ` Sugar, David [this message]
2018-12-22 19:20 ` Chris PeBenito
2018-12-23 10:20 ` Dominick Grift
2018-12-23 10:46 ` Dominick Grift
2018-12-23 16:09 ` Dominick Grift
2018-12-23 16:16 ` Dominick Grift
2018-12-22 19:28 ` [PATCH 1/2] Allow greeter to start dbus and transition Chris PeBenito
2018-12-23 16:33 ` Dominick Grift
2018-12-23 16:45 ` Dominick Grift
2018-12-23 16:52 ` Dominick Grift
2018-12-23 16:55 ` Dominick Grift
2018-12-23 17:02 ` Dominick Grift
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d2d6c7f-3084-d6f6-ce1b-42c9d9535969@tresys.com \
--to=dsugar@tresys.com \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).