From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB419C31E50 for ; Sat, 15 Jun 2019 19:24:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FE182184B for ; Sat, 15 Jun 2019 19:24:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ieee.org header.i=@ieee.org header.b="ZF9+HgJ6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725535AbfFOTYG (ORCPT ); Sat, 15 Jun 2019 15:24:06 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:40752 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725270AbfFOTYG (ORCPT ); Sat, 15 Jun 2019 15:24:06 -0400 Received: by mail-qk1-f193.google.com with SMTP id c70so3855157qkg.7 for ; Sat, 15 Jun 2019 12:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=km0rD1UOjNeX+YYlvavvg6SY851eXoyBviL7opftzME=; b=ZF9+HgJ6jXUs18DYb+jpxlFgUul24Agf2uYsT44EowPAgyhGv3CDJy5gw5YDZGQikk mG9TC541UO4TGjbfIa48phbB7XJCeQ4Al2/nLUuqzJUuKvugvCJIrO0ndcy6IyqvisR8 X1sRobzWEhBaCQpYge9C5HI1KRtkEqn+70YQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=km0rD1UOjNeX+YYlvavvg6SY851eXoyBviL7opftzME=; b=iZG3MPxBqrsGTWTq/0Upbkxma2OhxEoqyLFnPKCS1/p3Mt4DSrXWm9i+BRNF8bySIi Ml8LhS0rc1FJi9wPEpmGb9c/ajF4YKoMd78/HL9yJaUfJJMNPYBRMxdF6wX0T6BEnbmH 65oQ/JDyeZAph6ArdDxPli5zBwoYMMLcH1JDF62z7AgKeaMZRUWso+ALBSAJQVRDQq2+ CPzZ7a6A62Za53bR78WnJBTdNdXEBGkK157XHxF4PiOPlVY3X2zBUKMnEYMz/pXgZfTu c2r+2Iuw+gyE/amuH2TVP3TjgUDwmk84k28mJwIhdCoWLZfIHKY2jU/V5Ux0an49UeRY RPwg== X-Gm-Message-State: APjAAAWmX57AOaXZTlnU8cczPCdsdDzCNw7wL7dnBY43SEnVDYXMImQJ vGwMNsVXviyHdMxJXhg7RxT05h7ttWI= X-Google-Smtp-Source: APXvYqzodYfH5de1tWP60H1Wf1gpcMg2w/7Xcf7CuglcTnKYOR0xE4PGmH3wnezEi0auKQYCKWCW2g== X-Received: by 2002:a37:dd4:: with SMTP id 203mr15463082qkn.326.1560626644716; Sat, 15 Jun 2019 12:24:04 -0700 (PDT) Received: from [192.168.1.190] (pool-108-15-23-247.bltmmd.fios.verizon.net. [108.15.23.247]) by smtp.gmail.com with ESMTPSA id y42sm5079019qtc.66.2019.06.15.12.24.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jun 2019 12:24:04 -0700 (PDT) Subject: Re: [PATCH] add lldpd policy To: Alexander Miroshnichenko , selinux-refpolicy@vger.kernel.org References: <20190610142004.2719-1-alex@millerson.name> <749388e0-6da1-4b06-c62c-35302a5aba78@ieee.org> <20190615175859.GA2818@brutus.lan> From: Chris PeBenito Message-ID: <3d0d13b8-3090-558e-23b6-7edaeeff3f92@ieee.org> Date: Sat, 15 Jun 2019 15:24:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190615175859.GA2818@brutus.lan> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On 6/15/19 1:58 PM, Dominick Grift wrote: > On Sat, Jun 15, 2019 at 12:08:16PM -0400, Chris PeBenito wrote: >> On 6/10/19 10:20 AM, Alexander Miroshnichenko wrote: >>> +allow lldpd_t self:process { fork signal_perms }; >>> +allow lldpd_t self:fifo_file rw_fifo_file_perms; >>> +allow lldpd_t self:unix_stream_socket { accept listen }; >> >> These perms should probably be create_stream_socket_perms. > > the other permissions are already provided with logging_send_syslog_msg() so would be reduntant This is true. However,the syslog socket is not the only socket in use. Since it also listens on its own stream socket, the create_stream_socket_perms more clearly shows the intent. -- Chris PeBenito