From: Chris PeBenito <pebenito@ieee.org>
To: "Sugar, David" <dsugar@tresys.com>,
"selinux-refpolicy@vger.kernel.org"
<selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH] Resolve some denials related to sending journal messages
Date: Sun, 7 Apr 2019 20:52:50 -0400 [thread overview]
Message-ID: <48f4a705-36e6-aca7-15e4-1c100785aaf8@ieee.org> (raw)
In-Reply-To: <20190404122900.8945-2-dsugar@tresys.com>
On 4/4/19 8:29 AM, Sugar, David wrote:
> type=AVC msg=audit(1554324562.840:159): avc: denied { sendto } for pid=7277 comm="systemd-backlig" path="/run/systemd/journal/socket" scontext=system_u:system_r:systemd_backlight_t:s0 tcontext=system_u:system_r:kernel_t:s0 tclass=unix_dgram_socket permissive=1
> type=AVC msg=audit(1554324271.863:245): avc: denied { sendto } for pid=7421 comm="systemd-user-se" path="/run/systemd/journal/socket" scontext=system_u:system_r:systemd_sessions_t:s0 tcontext=system_u:system_r:kernel_t:s0 tclass=unix_dgram_socket permissive=0
> type=AVC msg=audit(1554324635.844:313): avc: denied { sendto } for pid=7744 comm="systemd-cryptse" path="/run/systemd/journal/socket" scontext=system_u:system_r:lvm_t:s0 tcontext=system_u:system_r:kernel_t:s0 tclass=unix_dgram_socket permissive=1
I think we've reached the limit of the explicit kernel_dgram_send() and
it's time to reevaluate putting this in logging_send_syslog_msg().
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
> policy/modules/system/lvm.te | 1 +
> policy/modules/system/systemd.te | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/policy/modules/system/lvm.te b/policy/modules/system/lvm.te
> index ec3b4a18..aea199d4 100644
> --- a/policy/modules/system/lvm.te
> +++ b/policy/modules/system/lvm.te
> @@ -222,6 +222,7 @@ filetrans_pattern(lvm_t, lvm_etc_t, lvm_metadata_t, file)
> files_etc_filetrans(lvm_t, lvm_metadata_t, file)
> files_search_mnt(lvm_t)
>
> +kernel_dgram_send(lvm_t)
> kernel_request_load_module(lvm_t)
> kernel_get_sysvipc_info(lvm_t)
> kernel_read_system_state(lvm_t)
> diff --git a/policy/modules/system/systemd.te b/policy/modules/system/systemd.te
> index f6455f6f..541117a9 100644
> --- a/policy/modules/system/systemd.te
> +++ b/policy/modules/system/systemd.te
> @@ -228,6 +228,8 @@ dev_rw_sysfs(systemd_backlight_t)
> # for udev.conf
> files_read_etc_files(systemd_backlight_t)
>
> +kernel_dgram_send(systemd_backlight_t)
> +
> # for /run/udev/data/+backlight*
> udev_read_pid_files(systemd_backlight_t)
>
> @@ -981,6 +983,8 @@ allow systemd_sessions_t self:process setfscreate;
> allow systemd_sessions_t systemd_sessions_var_run_t:file manage_file_perms;
> files_pid_filetrans(systemd_sessions_t, systemd_sessions_var_run_t, file)
>
> +kernel_dgram_send(systemd_sessions_t)
> +
> selinux_get_enforce_mode(systemd_sessions_t)
> selinux_get_fs_mount(systemd_sessions_t)
>
>
--
Chris PeBenito
next prev parent reply other threads:[~2019-04-08 0:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 12:29 [PATCH] Add interface xdm_run_domain Sugar, David
2019-04-04 12:29 ` [PATCH] Resolve some denials related to sending journal messages Sugar, David
2019-04-08 0:52 ` Chris PeBenito [this message]
2019-04-08 13:33 ` Sugar, David
2019-04-08 13:41 ` Dominick Grift
2019-04-08 13:56 ` Sugar, David
2019-04-08 0:52 ` [PATCH] Add interface xdm_run_domain Chris PeBenito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48f4a705-36e6-aca7-15e4-1c100785aaf8@ieee.org \
--to=pebenito@ieee.org \
--cc=dsugar@tresys.com \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).