selinux-refpolicy.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell Coker <russell@coker.com.au>
To: "Sugar, David" <dsugar@tresys.com>
Cc: Chris PeBenito <pebenito@ieee.org>,
	"selinux-refpolicy@vger.kernel.org" 
	<selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH] Add kernel_dgram_send() into logging_send_syslog_msg()
Date: Sun, 14 Apr 2019 01:40:36 +1000	[thread overview]
Message-ID: <5853619.lIKEncWOjy@xev> (raw)
In-Reply-To: <52d3b5f4-532d-ab8c-3941-47817d0b3489@tresys.com>

On Sunday, 14 April 2019 1:36:07 AM AEST Sugar, David wrote:
> >>> Why is a socket that everything sends to labeled as kernel_t?
> >>
> >> Russell, you aren't seeing this type of access on Debian?
> > 
> > 
> > 
> > 
> >          ifdef(`init_systemd',`
> >          
> >                  init_domain($1, $2)
> >                  # this may be because of late labelling
> >                  kernel_dgram_send($1)
> > 
> > 
> > 
> >                  allow $1 init_t:unix_dgram_socket sendto;
> >          
> >          ')
> > 
> > 
> > The above is in the upstream policy in the init_daemon_domain()
> > interface.
> > Not sure why.
> > 
> > I've put in an auditallow rule and so far haven't been able to reproduce
> > it.
> > So we can probably remove that line.
> > 
> 
> 
> Upstream RHEL is setting up the attribute 'syslog_client_type', has 
> 'typeattribute $1 syslog_client_type' in logging_send_syslog_msg ()
> 
> and then
> ifdef(`hide_broken_symptoms',`
> 	kernel_dgram_send(syslog_client_type)
> ')
> in logging.te

Well they are stating that it's a symptom of brokenness...

> When not allowing this access I get a RHEL system that will not boot. 
> I'm happy to put this in an 'ifdef distro_redhat'.  Please let me know 
> the preference on how to proceed.

Yes ifdef distro_redhat seems like a good idea.

-- 
My Main Blog         http://etbe.coker.com.au/
My Documents Blog    http://doc.coker.com.au/


      reply	other threads:[~2019-04-13 15:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 15:09 [PATCH] Add kernel_dgram_send() into logging_send_syslog_msg() Sugar, David
2019-04-10  1:00 ` Russell Coker
2019-04-10  1:07   ` Sugar, David
2019-04-10  1:39     ` Russell Coker
2019-04-10 14:16       ` Sugar, David
2019-04-12 11:54       ` Chris PeBenito
2019-04-13  5:35         ` Russell Coker
2019-04-13 15:36           ` Sugar, David
2019-04-13 15:40             ` Russell Coker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5853619.lIKEncWOjy@xev \
    --to=russell@coker.com.au \
    --cc=dsugar@tresys.com \
    --cc=pebenito@ieee.org \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).