From: Chris PeBenito <pebenito@ieee.org>
To: Jason Zaman <jason@perfinion.com>, selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH 06/10] policykit devicekit: Add watch perms
Date: Mon, 17 Feb 2020 13:28:26 -0500 [thread overview]
Message-ID: <6a095c4f-6323-5ade-0aae-88d3f10c770d@ieee.org> (raw)
In-Reply-To: <20200216200319.39337-6-jason@perfinion.com>
On 2/16/20 3:03 PM, Jason Zaman wrote:
> avc: denied { watch } for pid=12488 comm="gmain" path="/etc" dev="zfs" ino=1436 scontext=system_u:system_r:devicekit_disk_t:s0-s0:c0.c1023 tcontext=system_u:object_r:etc_t:s0 tclass=dir permissive=0
> avc: denied { watch } for pid=6452 comm="gmain" path="/run/ConsoleKit" dev="tmpfs" ino=17611 scontext=system_u:system_r:policykit_t:s0-s0:c0.c1023 tcontext=system_u:object_r:consolekit_runtime_t:s0 tclass=dir permissive=0
> avc: denied { watch } for pid=6452 comm="gmain" path="/usr/share/polkit-1/actions" dev="zfs" ino=235638 scontext=system_u:system_r:policykit_t:s0-s0:c0.c1023 tcontext=system_u:object_r:usr_t:s0 tclass=dir permissive=0
> avc: denied { watch } for pid=6452 comm="gmain" path="/etc/polkit-1/rules.d" dev="zfs" ino=268215 scontext=system_u:system_r:policykit_t:s0-s0:c0.c1023 tcontext=system_u:object_r:etc_t:s0 tclass=dir permissive=0
> Signed-off-by: Jason Zaman <jason@perfinion.com>
> ---
> policy/modules/services/consolekit.if | 18 ++++++++++++++++++
> policy/modules/services/devicekit.te | 1 +
> policy/modules/services/policykit.te | 3 +++
> 3 files changed, 22 insertions(+)
>
> diff --git a/policy/modules/services/consolekit.if b/policy/modules/services/consolekit.if
> index 9aa0dbce..422c19cd 100644
> --- a/policy/modules/services/consolekit.if
> +++ b/policy/modules/services/consolekit.if
> @@ -121,3 +121,21 @@ interface(`consolekit_read_pid_files',`
> allow $1 consolekit_runtime_t:dir list_dir_perms;
> read_files_pattern($1, consolekit_runtime_t, consolekit_runtime_t)
> ')
> +
> +########################################
> +## <summary>
> +## Watch consolekit runtime dir.
> +## </summary>
> +## <param name="domain">
> +## <summary>
> +## Domain allowed access.
> +## </summary>
> +## </param>
> +#
> +interface(`consolekit_watch_runtime_dir',`
> + gen_require(`
> + type consolekit_runtime_t;
> + ')
> +
> + allow $1 consolekit_runtime_t:dir watch;
> +')
> diff --git a/policy/modules/services/devicekit.te b/policy/modules/services/devicekit.te
> index f58a7a19..ed88f10b 100644
> --- a/policy/modules/services/devicekit.te
> +++ b/policy/modules/services/devicekit.te
> @@ -127,6 +127,7 @@ files_manage_boot_dirs(devicekit_disk_t)
> files_manage_mnt_dirs(devicekit_disk_t)
> files_read_etc_runtime_files(devicekit_disk_t)
> files_read_usr_files(devicekit_disk_t)
> +files_watch_etc_dirs(devicekit_disk_t)
>
> fs_getattr_all_fs(devicekit_disk_t)
> fs_list_inotifyfs(devicekit_disk_t)
> diff --git a/policy/modules/services/policykit.te b/policy/modules/services/policykit.te
> index 04e88500..4989157c 100644
> --- a/policy/modules/services/policykit.te
> +++ b/policy/modules/services/policykit.te
> @@ -95,6 +95,8 @@ dev_read_urand(policykit_t)
> domain_read_all_domains_state(policykit_t)
>
> files_dontaudit_search_all_mountpoints(policykit_t)
> +files_watch_etc_dirs(policykit_t)
> +files_watch_usr_dirs(policykit_t)
>
> fs_getattr_xattr_fs(policykit_t)
> fs_list_inotifyfs(policykit_t)
> @@ -127,6 +129,7 @@ optional_policy(`
>
> optional_policy(`
> consolekit_read_pid_files(policykit_t)
> + consolekit_watch_runtime_dir(policykit_t)
> ')
>
> optional_policy(`
Merged.
--
Chris PeBenito
next prev parent reply other threads:[~2020-02-17 18:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-16 20:03 [PATCH 01/10] fstools: add zfs-auto-snapshot Jason Zaman
2020-02-16 20:03 ` [PATCH 02/10] udev: Add watch perms Jason Zaman
2020-02-17 18:27 ` Chris PeBenito
2020-02-16 20:03 ` [PATCH 03/10] accountsd: " Jason Zaman
2020-02-17 18:27 ` Chris PeBenito
2020-02-16 20:03 ` [PATCH 04/10] cron: watch cron spool Jason Zaman
2020-02-17 18:28 ` Chris PeBenito
2020-02-16 20:03 ` [PATCH 05/10] colord: add watch perms Jason Zaman
2020-02-17 18:27 ` Chris PeBenito
2020-02-16 20:03 ` [PATCH 06/10] policykit devicekit: Add " Jason Zaman
2020-02-17 18:28 ` Chris PeBenito [this message]
2020-02-16 20:03 ` [PATCH 07/10] userdomain: Add watch on home dirs Jason Zaman
2020-02-17 18:31 ` Chris PeBenito
2020-02-16 20:03 ` [PATCH 08/10] dbus: add watch perms Jason Zaman
2020-02-17 18:28 ` Chris PeBenito
2020-02-16 20:03 ` [PATCH 09/10] chromium: watch etc dirs Jason Zaman
2020-02-16 20:03 ` [PATCH 10/10] gpg: add watch perms for agent Jason Zaman
2020-02-17 18:26 ` [PATCH 01/10] fstools: add zfs-auto-snapshot Chris PeBenito
-- strict thread matches above, loose matches on Subject: below --
2020-02-16 8:54 Jason Zaman
2020-02-16 8:54 ` [PATCH 06/10] policykit devicekit: Add watch perms Jason Zaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a095c4f-6323-5ade-0aae-88d3f10c770d@ieee.org \
--to=pebenito@ieee.org \
--cc=jason@perfinion.com \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).