SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
From: Chris PeBenito <pebenito@ieee.org>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: refpolicy <selinux-refpolicy@vger.kernel.org>
Subject: Re: [RFC] Rename *_var_run_t to *_runtime_t
Date: Mon, 16 Sep 2019 20:52:32 -0400
Message-ID: <7a4077a7-e889-226a-26c3-891db800755d@ieee.org> (raw)
In-Reply-To: <CAJfZ7=khMjHJ01jCXkrTZ2sCypGjW9ZP2fZ0NOYTvynDFQhRCw@mail.gmail.com>

On 9/15/19 6:33 AM, Nicolas Iooss wrote:
> On Sat, Sep 14, 2019 at 11:52 PM Chris PeBenito <pebenito@ieee.org> wrote:
>>
>> /var/run has moved to /run on most systems and it's use has increased
>> beyond pid files and sockets. Because of this, new types used in /run
>> have for some time followed the convention *_runtime_t. This change
>> would rename all *_var_run_t types to *_runtime_t.
>>
>> Since this adds many aliases to the policy, the patch set also drops all
>> old backwards-compatibility aliases.
>>
>> https://github.com/SELinuxProject/refpolicy/pull/106
>>
>> Any objections to this?
> 
> Hello,
> I agree with this change.
> 
> When I loaded the policy with your patch on my test system, my kernel
> logs issued a warning:
> 
> SELinux:  Context sysadm_u:sysadm_r:samba_net_t became invalid (unmapped).
> SELinux:  Context sysadm_u:sysadm_r:smbcontrol_t became invalid (unmapped).
> SELinux:  Context sysadm_u:sysadm_r:winbind_helper_t became invalid (unmapped).
> 
> This is because the following optional block from sysadm.te is now dropped:
> 
> optional_policy(`
> samba_admin(sysadm_t, sysadm_r)
> samba_run_smbcontrol(sysadm_t, sysadm_r)
> samba_run_smbmount(sysadm_t, sysadm_r)
> samba_run_net(sysadm_t, sysadm_r)
> samba_run_winbind_helper(sysadm_t, sysadm_r)
> ')
> 
> This block is dropped because it required two types that are not
> defined: nmbd_runtime_t and smbd_runtime_t.
> 
> In the current refpolicy (git master), there is:
> 
> typealias samba_var_run_t alias { nmbd_var_run_t smbd_var_run_t };
> 
> Your pull request changes this to:
> 
> typealias samba_runtime_t alias { nmbd_var_run_t smbd_var_run_t };
> 
> Should nmbd_runtime_t and smbd_runtime_t be changed to samba_runtime_t
> in interface samba_admin()?

Yes. There was another interface that also had that issue.  I updated 
the PR to fix it.


> Other than that, I did not find other issues.
> 
> Thanks,
> Nicolas
> 


-- 
Chris PeBenito

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-14 21:51 Chris PeBenito
2019-09-15 10:33 ` Nicolas Iooss
2019-09-17  0:52   ` Chris PeBenito [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a4077a7-e889-226a-26c3-891db800755d@ieee.org \
    --to=pebenito@ieee.org \
    --cc=nicolas.iooss@m4x.org \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org selinux-refpolicy@archiver.kernel.org
	public-inbox-index selinux-refpolicy

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/ public-inbox