From: Dominick Grift <dac.override@gmail.com> To: "Sugar\, David" <dsugar@tresys.com> Cc: "selinux-refpolicy\@vger.kernel.org" <selinux-refpolicy@vger.kernel.org> Subject: Re: [PATCH] Allow AIDE to sendto kernel datagram socket Date: Tue, 26 Feb 2019 13:32:55 +0100 Message-ID: <87lg22afwo.fsf@gmail.com> (raw) In-Reply-To: <eeedb7d7-e2e6-6da2-7e2d-2e55f3f4f0cf@tresys.com> (David Sugar's message of "Tue, 26 Feb 2019 12:28:10 +0000") "Sugar, David" <dsugar@tresys.com> writes: > On 2/26/19 1:52 AM, Dominick Grift wrote: >> "Sugar, David" <dsugar@tresys.com> writes: >> >>> type=AVC msg=audit(1550799594.394:205): avc: denied { sendto } for >>> pid=7182 comm="aide" path="/dev/log" >>> scontext=system_u:system_r:aide_t:s0 >>> tcontext=system_u:system_r:kernel_t:s0 tclass=unix_dgram_socket >>> permissive=1 >> >> Is this not part of logging_send_syslog_msg()? It should be AFAIK. >> > Looking at logging.if I don't see any kernel interfaces used. So, no it > isn't in there currently. Based on how logging seems to now work with > journald it might be a good idea to move these individual uses and just > rely on the loggin_send_syslog_msg interface to take care of it. > I see. I will let other decides on how to deal with this. In dssp2 i have: (call sys.unix_dgram_socket_sendto (client_subj_type_attribute)) (call sys.unix_stream_socket_connectto (client_subj_type_attribute)) Not sure why i also added the "unix_stream_socket connectto;", but i suppose there was a need for it at some point at least. > I'm happy to make this change if that is desired. > >>> >>> Signed-off-by: Dave Sugar <dsugar@tresys.com> >>> --- >>> policy/modules/admin/aide.te | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/policy/modules/admin/aide.te b/policy/modules/admin/aide.te >>> index 9d3c19ce..6297b60e 100644 >>> --- a/policy/modules/admin/aide.te >>> +++ b/policy/modules/admin/aide.te >>> @@ -35,6 +35,8 @@ logging_log_filetrans(aide_t, aide_log_t, file) >>> files_read_all_files(aide_t) >>> files_read_all_symlinks(aide_t) >>> >>> +kernel_dgram_send(aide_t) >>> + >>> logging_send_audit_msgs(aide_t) >>> logging_send_syslog_msg(aide_t) >> -- Key fingerprint = 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02 https://sks-keyservers.net/pks/lookup?op=get&search=0x3B6C5F1D2C7B6B02 Dominick Grift
next prev parent reply index Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-25 23:37 [PATCH] Fix incorrect type in clamav_enableddisable_clamd interface Sugar, David 2019-02-25 23:37 ` [PATCH] Allow freshclam to read sysctl_crypto_t Sugar, David 2019-02-27 3:22 ` Chris PeBenito 2019-02-25 23:37 ` [PATCH] Add interfaces to run freshclam Sugar, David 2019-02-27 3:22 ` Chris PeBenito 2019-02-25 23:37 ` [PATCH] Allow AIDE to sendto kernel datagram socket Sugar, David 2019-02-26 6:52 ` Dominick Grift 2019-02-26 12:28 ` Sugar, David 2019-02-26 12:32 ` Dominick Grift [this message] 2019-02-27 3:21 ` Chris PeBenito 2019-02-25 23:37 ` [PATCH] Allow AIDE to mmap files Sugar, David 2019-02-27 3:22 ` Chris PeBenito 2019-02-25 23:37 ` [PATCH] Allow AIDE to read kernel sysctl_crypto_t Sugar, David 2019-02-27 3:22 ` Chris PeBenito 2019-02-27 3:23 ` [PATCH] Fix incorrect type in clamav_enableddisable_clamd interface Chris PeBenito
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87lg22afwo.fsf@gmail.com \ --to=dac.override@gmail.com \ --cc=dsugar@tresys.com \ --cc=selinux-refpolicy@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
SELinux-Refpolicy Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \ selinux-refpolicy@vger.kernel.org public-inbox-index selinux-refpolicy Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy AGPL code for this site: git clone https://public-inbox.org/public-inbox.git