From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D600C433DB for ; Mon, 18 Jan 2021 23:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F123222E03 for ; Mon, 18 Jan 2021 23:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731135AbhARXeh (ORCPT ); Mon, 18 Jan 2021 18:34:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726601AbhARXef (ORCPT ); Mon, 18 Jan 2021 18:34:35 -0500 Received: from smtp.sws.net.au (smtp.sws.net.au [IPv6:2a01:4f8:140:71f5::dada:cafe]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A85EC061573 for ; Mon, 18 Jan 2021 15:33:51 -0800 (PST) Received: from liv.coker.com.au (unknown [103.75.204.226]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: russell@coker.com.au) by smtp.sws.net.au (Postfix) with ESMTPSA id DAD78F553; Tue, 19 Jan 2021 10:33:46 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coker.com.au; s=2008; t=1611012827; bh=RtMkfJIUd3ZwToXtrFuZwzJUwaNB+RmDzcgCaA6I7MY=; l=1820; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yGWFcvJilbEEvk4larqrxXL9J+jRdCGaFYYnQcPqTkrtXXSNJ5mr9GBi/9+MaGke5 p/PlPY4tuAgBUo6aD3Fl5SeuaDnW0wxPjfA6SH2Wtu7AYHZUdP3XDWTsF6g0DcSLWv 7fSZevN6m/FlJHE8lk1aN0uC0tPevhtaDA2Sdi8k= From: Russell Coker To: Dominick Grift Cc: selinux-refpolicy@vger.kernel.org Subject: Re: [PATCH] matrixd (synapse) policy Date: Tue, 19 Jan 2021 10:33:30 +1100 Message-ID: <9533895.9IaMh57lMM@liv> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On Tuesday, 19 January 2021 2:07:06 AM AEDT Dominick Grift wrote: > > +allow matrixd_t self:fifo_file rw_file_perms; > > +allow matrixd_t self:tcp_socket create_stream_socket_perms; > > +allow matrixd_t self:netlink_route_socket rw_netlink_socket_perms; > > r_netlink_route_socket_perms probably r_netlink_socket_perms works. There isn't a r_netlink_route_socket_perms. > > +corenet_tcp_connect_http_port(matrixd_t) > > +corenet_tcp_connect_http_cache_port(matrixd_t) > > +corenet_udp_bind_generic_port(matrixd_t) > > +corenet_tcp_bind_http_port(matrixd_t) > > +corenet_udp_bind_reserved_port(matrixd_t) > > + > > +allow matrixd_t self:udp_socket create_socket_perms; > > +allow matrixd_t self:unix_dgram_socket { create getopt setopt write }; > > create_socket_perms Done. > > +# https://cffi.readthedocs.io/en/latest/using.html#callbacks > > +allow matrixd_t self:process execmem; > > + > > +can_exec(matrixd_t, { matrixd_tmp_t matrixd_var_t }) > > Are you sure that it requires "execute_no_trans" here and not just "map > execute"? Can you show the avc denials that prompted this rule to be added? I've removed that line and haven't been able to recreate whatever made me add it. I'll submit a new patch without it. > > + > > +kernel_read_system_state(matrixd_t) > > +kernel_search_fs_sysctls(matrixd_t) > > +kernel_read_vm_overcommit_sysctl(matrixd_t) > > +kernel_search_vm_sysctl(matrixd_t) > > + > > +corecmd_exec_bin(matrixd_t) > > +corecmd_shell_entry_type(matrixd_t) > > Why would the matrixd_t domain be entered via shell_exec_t? Can you show > the avc denials that prompted this rule to be added? corecmd_shell_entry_type() wasn't needed. Thanks for your review. -- My Main Blog http://etbe.coker.com.au/ My Documents Blog http://doc.coker.com.au/