SELinux-Refpolicy Archive on
 help / color / Atom feed
From: Nicolas Iooss <>
To: Chris PeBenito <>
Subject: Re: Adding a typo-checker for the .fc files of refpolicy
Date: Tue, 27 Aug 2019 23:20:03 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Aug 27, 2019 at 6:05 AM Chris PeBenito <> wrote:
> On 8/18/19 4:38 PM, Nicolas Iooss wrote:
> > Hello,
> >
> > After introducing a buggy file context in the policy (which will be
> > fixed with, I
> > decided to write a typo-checker for the .fc files. I am re-using some
> > code I have already written in order to label files in /usr/bin
> > correctly on Arch Linux (I wrote this for
> > It seems it
> > already caught another issue in policy/modules/services/monit.fc. The
> > "s9" seems to be a misspelling for "s0" in:
> >
> > /etc/rc\.d/init\.d/monit --
> > gen_context(system_u:object_r:monit_initrc_exec_t,s9)
> >
> > Is there an interest in having such a script in the repository? If
> What are the checks?
> > yes, in which directory?
> >
> > In my humble opinion, it would be nice to have such a script and to
> > make Travis-CI run it. I nevertheless feels uncomfortable with putting
> > it in the "support" directory, because it is not involved in building
> > or installing the reference policy. I am therefore suggesting creating
> > a new directory, named "bin" or "scripts". Such a directory would
> > contain scripts such as this typo-checker and some other scripts that
> > could be useful when working on refpolicy. What do you think about
> > this?
> "testing" might work too.

Let's got for "testing" then. I began with tests about the endings of
patterns, then added checks on patterns such as "(.*)?", etc. As the
first version of my checker is ready for comments/review, I opened a
Pull Request: I
tried to write understandable comments in order to make it easier to
know what is checked.


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2019-08-18 20:38 ` Nicolas Iooss
2019-08-27  4:05   ` Chris PeBenito
2019-08-27 21:20     ` Nicolas Iooss [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux-Refpolicy Archive on

Archives are clonable:
	git clone --mirror selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ \
	public-inbox-index selinux-refpolicy

Newsgroup available over NNTP:

AGPL code for this site: git clone public-inbox