SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: Chris PeBenito <pebenito@ieee.org>
Cc: selinux-refpolicy@vger.kernel.org
Subject: Re: Adding a typo-checker for the .fc files of refpolicy
Date: Tue, 27 Aug 2019 23:20:03 +0200
Message-ID: <CAJfZ7=nJyDMHGshcAvdjJB+XOc_vOS-xCVqv-HOfiLVJyY1Z+g@mail.gmail.com> (raw)
In-Reply-To: <a22349ba-246e-e3cc-aa56-a7407b52d1e4@ieee.org>

On Tue, Aug 27, 2019 at 6:05 AM Chris PeBenito <pebenito@ieee.org> wrote:
>
> On 8/18/19 4:38 PM, Nicolas Iooss wrote:
> > Hello,
> >
> > After introducing a buggy file context in the policy (which will be
> > fixed with https://github.com/SELinuxProject/refpolicy/pull/66), I
> > decided to write a typo-checker for the .fc files. I am re-using some
> > code I have already written in order to label files in /usr/bin
> > correctly on Arch Linux (I wrote this for
> > https://github.com/SELinuxProject/refpolicy/pull/19). It seems it
> > already caught another issue in policy/modules/services/monit.fc. The
> > "s9" seems to be a misspelling for "s0" in:
> >
> > /etc/rc\.d/init\.d/monit --
> > gen_context(system_u:object_r:monit_initrc_exec_t,s9)
> >
> > Is there an interest in having such a script in the repository? If
>
> What are the checks?
>
>
> > yes, in which directory?
> >
> > In my humble opinion, it would be nice to have such a script and to
> > make Travis-CI run it. I nevertheless feels uncomfortable with putting
> > it in the "support" directory, because it is not involved in building
> > or installing the reference policy. I am therefore suggesting creating
> > a new directory, named "bin" or "scripts". Such a directory would
> > contain scripts such as this typo-checker and some other scripts that
> > could be useful when working on refpolicy. What do you think about
> > this?
>
> "testing" might work too.

Let's got for "testing" then. I began with tests about the endings of
patterns, then added checks on patterns such as "(.*)?", etc. As the
first version of my checker is ready for comments/review, I opened a
Pull Request: https://github.com/SELinuxProject/refpolicy/pull/74. I
tried to write understandable comments in order to make it easier to
know what is checked.

Thanks,
Nicolas


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAJfZ7=ndO=f0p6Gb=5FaZWA05Ra8vrSnDGfwmCjepLs3SWVrcg@mail.gmail.com>
2019-08-18 20:38 ` Nicolas Iooss
2019-08-27  4:05   ` Chris PeBenito
2019-08-27 21:20     ` Nicolas Iooss [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfZ7=nJyDMHGshcAvdjJB+XOc_vOS-xCVqv-HOfiLVJyY1Z+g@mail.gmail.com' \
    --to=nicolas.iooss@m4x.org \
    --cc=pebenito@ieee.org \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org selinux-refpolicy@archiver.kernel.org
	public-inbox-index selinux-refpolicy


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/ public-inbox