From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: selinux-refpolicy@vger.kernel.org
Subject: Re: Why is /usr/include matched with /usr/inclu.e?
Date: Wed, 21 Aug 2019 22:29:40 +0200 [thread overview]
Message-ID: <CAJfZ7=nsmAsgA-8jsoavLNoxKO6dLU+6gYj5eFZMW9ODR7cn7Q@mail.gmail.com> (raw)
In-Reply-To: <20190821200243.GA5262@brutus.lan>
On Wed, Aug 21, 2019 at 10:02 PM Dominick Grift <dac.override@gmail.com> wrote:
>
> On Wed, Aug 21, 2019 at 09:57:14PM +0200, Nicolas Iooss wrote:
> > Hi all,
> >
> > While checking the patterns in refpolicy, I stumbled upon the
> > following line in
> > https://github.com/SELinuxProject/refpolicy/blob/RELEASE_2_20190609/policy/modules/kernel/files.fc#L200
> >
> > /usr/inclu.e(/.*)? gen_context(system_u:object_r:usr_t,s0)
>
> Probably to work around an m4-ism. There seems to be an m4 "include" built-in.
This seems to be a good explanation. The policy also uses workarounds
for "index" built-in, with:
/etc/amanda/.*/index`'(/.*)?
/var/lib/apt-xapian-inde(x)(/.*)?
In order not to introduce parentheses (which might change some
ordering in the way the paths are matched with the patterns), I am
thinking of replacing the pattern of /usr/include with:
/usr/includ[e](/.*)? gen_context(system_u:object_r:usr_t,s0)
... with a comment about working around a m4 issue.
Thanks,
Nicolas
> >
> > This pattern matches /usr/include and its content, but why is a dot
> > used? Which other directories can it match?
> >
> > The issue there is that a dot can match a slash, so the pattern also
> > matches /usr/inclu/e/, which seems strange. This pattern has been
> > introduced in the very early days of refpolicy's git repository,
> > according to https://github.com/SELinuxProject/refpolicy/commit/f8ec0ad43b54437e2d9f0e48a773a64dbd9e543c#diff-e333cb52d2139f7a71f0dfbd32c06f70R117.
> > Does anyone remember why the pattern for /usr/include is so special?
> >
> > Thanks,
> > Nicolas
> >
>
> --
> Key fingerprint = 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
> https://sks-keyservers.net/pks/lookup?op=get&search=0x3B6C5F1D2C7B6B02
> Dominick Grift
next prev parent reply other threads:[~2019-08-21 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 19:57 Why is /usr/include matched with /usr/inclu.e? Nicolas Iooss
2019-08-21 20:02 ` Dominick Grift
2019-08-21 20:29 ` Nicolas Iooss [this message]
2019-08-27 4:06 ` Chris PeBenito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfZ7=nsmAsgA-8jsoavLNoxKO6dLU+6gYj5eFZMW9ODR7cn7Q@mail.gmail.com' \
--to=nicolas.iooss@m4x.org \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).