From: Chris PeBenito <pebenito@ieee.org>
To: David Sugar <dsugar@tresys.com>,
"selinux-refpolicy@vger.kernel.org"
<selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH] Allow auditctl_t to read bin_t symlinks.
Date: Tue, 11 Dec 2018 17:53:47 -0500 [thread overview]
Message-ID: <b6874c74-41f1-2761-ce6b-e2e699ac753d@ieee.org> (raw)
In-Reply-To: <20181207001935.16566-1-dsugar@tresys.com>
On 12/6/18 7:20 PM, David Sugar wrote:
> on RHEL7 insmod, rmmod, modprobe (and others?) are a symlinks
> to ../bin/kmod. But policy didn't allow auditctl_t to follow
> that link.
>
> type=AVC msg=audit(1543853530.925:141): avc: denied { read } for
> pid=6937 comm="auditctl" name="insmod" dev="dm-1" ino=628383
> scontext=system_u:system_r:auditctl_t:s0
> tcontext=system_u:object_r:bin_t:s0 tclass=lnk_file permissive=0
> type=AVC msg=audit(1543853530.925:143): avc: denied { read } for
> pid=6937 comm="auditctl" name="rmmod" dev="dm-1" ino=628387
> scontext=system_u:system_r:auditctl_t:s0
> tcontext=system_u:object_r:bin_t:s0 tclass=lnk_file permissive=0
> type=AVC msg=audit(1543853530.926:145): avc: denied { read } for
> pid=6937 comm="auditctl" name="modprobe" dev="dm-1" ino=628386
> scontext=system_u:system_r:auditctl_t:s0
> tcontext=system_u:object_r:bin_t:s0 tclass=lnk_file permissive=0
> type=AVC msg=audit(1543853797.766:60): avc: denied { read } for
> pid=6942 comm="auditctl" name="insmod" dev="dm-1" ino=628383
> scontext=system_u:system_r:auditctl_t:s0
> tcontext=system_u:object_r:bin_t:s0 tclass=lnk_file permissive=1
>
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
> policy/modules/system/logging.te | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/policy/modules/system/logging.te b/policy/modules/system/logging.te
> index 7020a476..483084a5 100644
> --- a/policy/modules/system/logging.te
> +++ b/policy/modules/system/logging.te
> @@ -107,6 +107,8 @@ read_files_pattern(auditctl_t, auditd_etc_t, auditd_etc_t)
> allow auditctl_t auditd_etc_t:dir list_dir_perms;
> dontaudit auditctl_t auditd_etc_t:file map;
>
> +corecmd_search_bin(auditctl_t)
> +
> # Needed for adding watches
> files_getattr_all_dirs(auditctl_t)
> files_getattr_all_files(auditctl_t)
Merged.
--
Chris PeBenito
prev parent reply other threads:[~2018-12-11 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 0:20 [PATCH] Allow auditctl_t to read bin_t symlinks David Sugar
2018-12-11 22:53 ` Chris PeBenito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6874c74-41f1-2761-ce6b-e2e699ac753d@ieee.org \
--to=pebenito@ieee.org \
--cc=dsugar@tresys.com \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).