From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92019C433DB for ; Fri, 12 Mar 2021 15:04:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67D6164F78 for ; Fri, 12 Mar 2021 15:04:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbhCLPEE (ORCPT ); Fri, 12 Mar 2021 10:04:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231351AbhCLPDw (ORCPT ); Fri, 12 Mar 2021 10:03:52 -0500 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99165C061574 for ; Fri, 12 Mar 2021 07:03:51 -0800 (PST) Received: by mail-qt1-x830.google.com with SMTP id 94so3924775qtc.0 for ; Fri, 12 Mar 2021 07:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=K5YqNOXid4mcmkvggGywPg7CxWclX1wIUY+ctG/tfmE=; b=Zu4NDgKl9CKftcXUlHQSQnOXRitiP0iZp2nDcZVoBYfjcqxgAaJt8pJEyuH7US9Szb 8Mfm7bPwQYxQ9Lbz/HWttTTM1BIV9W884KC0RB99BPEd3loxrZnKxhKh7bjnKoy9adFl DFl+TD85PlEh9Skda0u4Ax1SLO9dZ3NPejBGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=K5YqNOXid4mcmkvggGywPg7CxWclX1wIUY+ctG/tfmE=; b=cQpqgfp37O31od9StmvcuK+gr0gTKlzspA1Jbas9gpgV1AUPS2m9Vjpi8/czIPbw5i Qy18WfUV3d8+kcyuSq4e0qWZ47X4d3oS/CsRt2jAjsh19dKAh8S8fe6gCI/U4Yqsjzzb X2eb0dOuFd+kN/weLcDpET9w6M3Sy32YSTG7piT4UctO5IbzPTZksNiMumKxVKRFcMNF lYEkZKcHhIQOe9C7/O/+LTFA6vJkijFJm7IiiNm7K9SpS5hZjX2cCv9FtBMqPZY7xxlN FD2rsvynx6qq7blEPGaSxhjUs6WTTJKMZHenGLnwb9jZUR6cCZ4dCOkWun3EdFPMbztR 9pkw== X-Gm-Message-State: AOAM531SgGeKK9cS3PxXBL4SIsOsvTYIFUSnffV97xFX9sTf0V41lTnN G1seQL+pQJAmTIbsrw6iAIA+0O/Nyv9itg== X-Google-Smtp-Source: ABdhPJxo+rtRmE8U/+g4qqH+ZmC3enAejU1rAEvkPJM6Wgakq04tOAdsRaJ13g9P0ehVbtRsCwzU8A== X-Received: by 2002:a05:622a:48d:: with SMTP id p13mr7781838qtx.21.1615561430540; Fri, 12 Mar 2021 07:03:50 -0800 (PST) Received: from fedora.pebenito.net (pool-96-234-173-17.bltmmd.fios.verizon.net. [96.234.173.17]) by smtp.gmail.com with ESMTPSA id z5sm4459293qkz.2.2021.03.12.07.03.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Mar 2021 07:03:50 -0800 (PST) Subject: Re: [PATCH] rasdaemon (replacement for mcelog) To: Dominick Grift , Russell Coker Cc: selinux-refpolicy@vger.kernel.org References: From: Chris PeBenito Message-ID: Date: Fri, 12 Mar 2021 10:03:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On 3/8/21 3:59 AM, Dominick Grift wrote: > Dominick Grift writes: > >> Russell Coker writes: >> >>> This is policy for rasdaemon, the new replacement for mcelog. The >>> /dev/mcelog device is now an obsolete kernel feature that can be enabled >>> for backward compatibility and rasdaeon with tracefs is the new way. >>> >>> I've tested this and it seems to work OK, but all my servers are working >>> well so I haven't been able to test the case of actually detecting an >>> error. It would be good if someone with a known damaged server could give >>> it a go. >>> >>> I think this is ready for merging. >>> >>> Signed-off-by: Russell Coker >>> [...] >>> +++ refpolicy-2.20210203/policy/modules/services/rasdaemon.te >>> @@ -0,0 +1,49 @@ >>> +policy_module(rasdaemon, 1.0.0) >>> + >>> +# rasdaemon is a RAS (Reliability, Availability and Serviceability) logging >>> +# tool. It currently records memory errors, using the EDAC tracing events. >>> +# EDAC are drivers in the Linux kernel that handle detection of ECC errors >>> +# from memory controllers for most chipsets on x86 and ARM architectures. >>> +# >>> +# https://git.infradead.org/users/mchehab/rasdaemon.git >> >> Please use the for description. We have an api >> browser (make doc) and the description should end up there as well. >> >> Reliability, Availability and Serviceability (RAS) logging tool. >> >> I would omit the url because those are often subject to change anyway. I agree if we have this amount of description it should go in the XML, but the module level actually has a tag that goes after . I like Dominick's summary, but the Russel's comment can go in the module . The URL can remain. Yes, it can change, but at least there are some breadcrumbs if this program becomes obsolete or unmaintained. -- Chris PeBenito