From: Chris PeBenito <pebenito@ieee.org>
To: Russell Coker <russell@coker.com.au>,
Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] /run/systemd/units/ links
Date: Thu, 10 Jan 2019 20:26:10 -0500 [thread overview]
Message-ID: <dedf3ce8-4e9f-2313-6799-bbc9dc3a8124@ieee.org> (raw)
In-Reply-To: <4532148.u2APPhryqx@liv>
On 1/10/19 7:28 PM, Russell Coker wrote:
> On Friday, 11 January 2019 10:08:22 AM AEDT Nicolas Iooss wrote:
>>> I guess this is a race between patches. Should be named
>>> init_read_pid_symlinks. Same feedback as GitHub PR
>>> https://github.com/SELinuxProject/refpolicy/pull/17
>>
>> I like "init_read_runtime_symlinks" more than "init_read_pid_symlinks"
>> so I have uploaded my Pull Request. If your prefer the second name, I
>> can change it again.
>> Compared to this patch, my PR does not use files_search_pids() but
>> directly read_lnk_files_pattern() like some other interfaces. I have
>> no strong preferences regarding this.
>
> I'm really not bothered by the name. Whatever gets it included in git the
> fastest is good for me.
>
> Also I'd really like to see a new upstream release before the end of the month
> if convenient.
I've merged the PR, though this means the init_*_pid_*() interfaces will
need to be deprecated and replaced, for consistency.
--
Chris PeBenito
prev parent reply other threads:[~2019-01-11 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 11:41 [PATCH] /run/systemd/units/ links Russell Coker
2019-01-10 0:29 ` Chris PeBenito
2019-01-10 23:08 ` Nicolas Iooss
2019-01-11 0:28 ` Russell Coker
2019-01-11 1:26 ` Chris PeBenito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dedf3ce8-4e9f-2313-6799-bbc9dc3a8124@ieee.org \
--to=pebenito@ieee.org \
--cc=nicolas.iooss@m4x.org \
--cc=russell@coker.com.au \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).