SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
From: "Sugar, David" <dsugar@tresys.com>
To: Chris PeBenito <pebenito@ieee.org>,
	"selinux-refpolicy@vger.kernel.org" 
	<selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH v2] Allow systemd to getattr configfile
Date: Tue, 21 Jan 2020 14:22:31 +0000
Message-ID: <e3d46fe3-cb30-5740-f13f-c15e67a366ff@tresys.com> (raw)
In-Reply-To: <413d1a7d-224f-49eb-6a51-dab0a6227804@ieee.org>



On 1/21/20 8:42 AM, Chris PeBenito wrote:
> On 1/13/20 1:27 PM, Sugar, David wrote:
>> v2 update - rework, creating interface 'init_systemd_conditional'
>> as suggested.  This grants getattr access to the type provided.
>>
>> Signed-off-by: Dave Sugar <dsugar@tresys.com>
>> ---
>>   policy/modules/services/chronyd.te |  2 ++
>>   policy/modules/system/init.if      | 26 ++++++++++++++++++++++++++
>>   2 files changed, 28 insertions(+)
>>
>> diff --git a/policy/modules/services/chronyd.te 
>> b/policy/modules/services/chronyd.te
>> index 5e680d39..7ae8bb5a 100644
>> --- a/policy/modules/services/chronyd.te
>> +++ b/policy/modules/services/chronyd.te
>> @@ -102,6 +102,8 @@ miscfiles_read_localization(chronyd_t)
>>   chronyd_dgram_send_cli(chronyd_t)
>>   chronyd_read_config(chronyd_t)
>> +init_systemd_conditional(chronyd_conf_t)
>> +
>>   optional_policy(`
>>       gpsd_rw_shm(chronyd_t)
>>   ')
>> diff --git a/policy/modules/system/init.if 
>> b/policy/modules/system/init.if
>> index 62ab4da8..5a0a78bf 100644
>> --- a/policy/modules/system/init.if
>> +++ b/policy/modules/system/init.if
>> @@ -3232,6 +3232,32 @@ interface(`init_reload_all_units',`
>>       allow $1 { init_script_file_type systemdunit }:service reload;
>>   ')
>> +
>> +########################################
>> +## <summary>
>> +##      Allow init_t getattr permissions.  Generally
>> +##      needed for types that are used in a Condition
>> +##      predicate.
>> +## </summary>
>> +## <param name="domain">
>> +##      <summary>
>> +##      type accessible by init_t
>> +##      </summary>
>> +## </param>
>> +#
>> +interface(`init_systemd_conditional',`
> 
> systemd_ConditionPath is a more preferable name.
> 

I'm a little confused about the suggested name.  I think this interface 
belongs in init.if due to the requiring of init_t.  Due to this, I think 
it should have the init_ prefix.  I also don't think there are any camel 
case interface names.

Is the name 'init_systemd_condition_path' acceptable?  Or are some of my 
assumptions wrong?

> 
>> +    gen_require(`
>> +        type init_t;
>> +    ')
>> +    allow init_t $1:dir search_dir_perms;
>> +    allow init_t $1:lnk_file read_lnk_file_perms;
>> +    allow init_t $1:fifo_file getattr_fifo_file_perms;
>> +    allow init_t $1:sock_file getattr_sock_file_perms;
>> +    allow init_t $1:file getattr_file_perms;
>> +    allow init_t $1:blk_file getattr_blk_file_perms;
>> +    allow init_t $1:chr_file getattr_chr_file_perms;
>> +')
>> +
>>   ########################################
>>   ## <summary>
>>   ##      Allow unconfined access to send instructions to init
>>
> 
> 

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-13 18:27 Sugar, David
2020-01-21 13:42 ` Chris PeBenito
2020-01-21 14:22   ` Sugar, David [this message]
2020-01-22 10:41     ` Chris PeBenito

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3d46fe3-cb30-5740-f13f-c15e67a366ff@tresys.com \
    --to=dsugar@tresys.com \
    --cc=pebenito@ieee.org \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org
	public-inbox-index selinux-refpolicy

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git