SELinux-Refpolicy Archive on lore.kernel.org
 help / color / Atom feed
From: Laurent Bigonville <bigon@debian.org>
To: bauen1 <j2468h@googlemail.com>, selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] Also label polkit-agent-helper-1 when installed directly in /usr/libexec
Date: Wed, 22 Jul 2020 11:25:09 +0200
Message-ID: <eb0004b4-561b-54ab-7adf-188e3b882f70@debian.org> (raw)
In-Reply-To: <f720dee8-9917-45d6-8dcd-61d278b5f07f@gmail.com>

Le 22/07/20 à 11:15, bauen1 a écrit :
> Thanks,
>
> See https://salsa.debian.org/utopia-team/polkit/-/commit/f6f99d85b2eb91bd03ca56d30837d7291711a0f8 for the change in the debian package.
>
> On 7/22/20 10:59 AM, Laurent Bigonville wrote:
>> From: Laurent Bigonville <bigon@bigon.be>
>>
>> Debian now installs that executable directly in /usr/libexec for the
>> version 0.105
>>
>> Signed-off-by: Laurent Bigonville <bigon@bigon.be>
>> ---
>>   policy/modules/services/policykit.fc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/policy/modules/services/policykit.fc b/policy/modules/services/policykit.fc
>> index e2782838..85814b95 100644
>> --- a/policy/modules/services/policykit.fc
>> +++ b/policy/modules/services/policykit.fc
>> @@ -11,6 +11,7 @@
>>   # Systemd unit file
>>   /usr/lib/systemd/system/[^/]*polkit.*	--	gen_context(system_u:object_r:policykit_unit_t,s0)
>>   
>> +/usr/libexec/polkit-agent-helper-1	--	gen_context(system_u:object_r:policykit_auth_exec_t,s0)
> Since it is a debian only change, this should probably be wrapped in an ifdef distro_debian.

In the past this was done like that, but at some point I've been told to 
not use distro conditionals anymore. I can add it if you really want, 
but in the last year(s) it was not done for the other file contexts that 
were added.

>
>>   /usr/libexec/polkit-read-auth-helper	--	gen_context(system_u:object_r:policykit_auth_exec_t,s0)
>>   /usr/libexec/polkit-grant-helper.*	--	gen_context(system_u:object_r:policykit_grant_exec_t,s0)
>>   /usr/libexec/polkit-resolve-exe-helper.*	--	gen_context(system_u:object_r:policykit_resolve_exec_t,s0)
>>


      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  8:59 Laurent Bigonville
2020-07-22  9:15 ` bauen1
2020-07-22  9:25   ` Laurent Bigonville [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb0004b4-561b-54ab-7adf-188e3b882f70@debian.org \
    --to=bigon@debian.org \
    --cc=j2468h@googlemail.com \
    --cc=selinux-refpolicy@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux-Refpolicy Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux-refpolicy/0 selinux-refpolicy/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux-refpolicy selinux-refpolicy/ https://lore.kernel.org/selinux-refpolicy \
		selinux-refpolicy@vger.kernel.org
	public-inbox-index selinux-refpolicy

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux-refpolicy


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git