From: Stephen Smalley <sds@tycho.nsa.gov>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: SElinux list <selinux@vger.kernel.org>,
Petr Lautrbach <plautrba@redhat.com>
Subject: Re: [PATCH v2] python/sepolicy: call segenxml.py with python3
Date: Tue, 15 Oct 2019 10:17:40 -0400 [thread overview]
Message-ID: <0fddfce9-6f24-d793-f6b6-fc665ebdca15@tycho.nsa.gov> (raw)
In-Reply-To: <CAJfZ7=mQ1MwfWC-R+QM45runiOunGQqTq-cjA8LZptN1n8g-2w@mail.gmail.com>
On 10/10/19 3:48 PM, Nicolas Iooss wrote:
> On Wed, Oct 9, 2019 at 4:20 PM Stephen Smalley <sds@tycho.nsa.gov> wrote:
>>
>> Fixes: https://github.com/SELinuxProject/selinux/issues/61
>> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
>> ---
>> v2 wraps basedir + filename in parentheses as per Nicolas Iooss' suggestion.
>
> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Thanks, applied.
>
>>
>> python/sepolicy/sepolicy/interface.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/python/sepolicy/sepolicy/interface.py b/python/sepolicy/sepolicy/interface.py
>> index 583091ae18aa..187419fa7822 100644
>> --- a/python/sepolicy/sepolicy/interface.py
>> +++ b/python/sepolicy/sepolicy/interface.py
>> @@ -196,7 +196,7 @@ def get_xml_file(if_file):
>> from subprocess import getstatusoutput
>> basedir = os.path.dirname(if_file) + "/"
>> filename = os.path.basename(if_file).split(".")[0]
>> - rc, output = getstatusoutput("python /usr/share/selinux/devel/include/support/segenxml.py -w -m %s" % basedir + filename)
>> + rc, output = getstatusoutput("/usr/bin/python3 /usr/share/selinux/devel/include/support/segenxml.py -w -m %s" % (basedir + filename))
>> if rc != 0:
>> sys.stderr.write("\n Could not proceed selected interface file.\n")
>> sys.stderr.write("\n%s" % output)
>> --
>> 2.21.0
>>
>
prev parent reply other threads:[~2019-10-15 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 14:20 [PATCH v2] python/sepolicy: call segenxml.py with python3 Stephen Smalley
2019-10-10 19:48 ` Nicolas Iooss
2019-10-15 14:17 ` Stephen Smalley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fddfce9-6f24-d793-f6b6-fc665ebdca15@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=nicolas.iooss@m4x.org \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).