From: David Howells <dhowells@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: dhowells@redhat.com,
Richard Haines <richard_c_haines@btinternet.com>,
selinux@vger.kernel.org, paul@paul-moore.com
Subject: Re: [RFC PATCH 1/1] selinux: Add support for new key permissions
Date: Fri, 28 Feb 2020 15:55:34 +0000 [thread overview]
Message-ID: <103614.1582905334@warthog.procyon.org.uk> (raw)
In-Reply-To: <c5d6ae72-4f5d-fe41-c025-0eaa4616b7eb@tycho.nsa.gov>
Stephen Smalley <sds@tycho.nsa.gov> wrote:
> Regardless, we need to revert the original patch and create a new one that
> addresses the KEY_NEED_PARENT_JOIN issue I mentioned and that adds the
> key_perms capability in the right place in the first place, not apply a fix on
> top.
I think the problem is that selinux_key_permission() is munging the new perm
set into the old perm set and then passing that to avc_has_perm(). Really, we
need to work backwards if the SELinux policy is described in terms of the old
perm set.
Is there any way to make that possible?
David
next prev parent reply other threads:[~2020-02-28 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 18:10 [RFC PATCH 0/1] selinux: Add support for new key permissions Richard Haines
2020-02-20 18:10 ` [RFC PATCH 1/1] " Richard Haines
[not found] ` <c5d6ae72-4f5d-fe41-c025-0eaa4616b7eb@tycho.nsa.gov>
2020-02-21 0:03 ` Paul Moore
2020-02-21 10:55 ` Richard Haines
2020-02-28 15:52 ` David Howells
2020-02-28 16:08 ` Paul Moore
2020-02-28 15:55 ` David Howells [this message]
2020-02-28 17:22 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=103614.1582905334@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=paul@paul-moore.com \
--cc=richard_c_haines@btinternet.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).