SELinux Archive on lore.kernel.org
 help / color / Atom feed
From: bauen1 <j2468h@googlemail.com>
To: selinux <selinux@vger.kernel.org>
Subject: Invalid output by secilc with constraints containing 4 nested OR and a single AND
Date: Wed, 29 Jul 2020 21:05:47 +0200
Message-ID: <12fc8da1-4fbd-59f7-08e7-0af9daff118c@gmail.com> (raw)

Hello,
I've discovered that a constraint like

(constrain (file (open))
  (or
    (eq t1 exec_t) ; probably doesn't matter
    (or
      (eq t1 exec_t) ; probably doesn't matter
      (or
        (eq t1 exec_t) ; probably doesn't matter
        (or
          ; Making and the first argument to or will produce a valid policy
          (eq t1 exec_t)
          (and
            ; content probably doesn't matter
            (eq t1 exec_t)
            (eq t1 exec_t)
          )
        )
      )
    )
  )
)

allows secilc to finish compilation but generates a policy that is "invalid", file identifies it as an SELinux Binary Policy but seinfo and similiar tools refuse to operate on it.

For example (using secilc/test/policy.cil):
$ file policy.32 
policy.32: SE Linux policy v32 8 symbols 9 ocons
$ seinfo policy.32 -x --constrain
Invalid policy: policy.32. A binary policy must be specified. (use e.g. policy.32 or sepolicy) Source policies are not supported.

I've tested this with secilc 3.1-1 (debian) and from the current git master (9e2b8c61bfd275d0f007a736721c557755edf4a0)

I hope that this is enough information to reproduce the issue.

-- 
bauen1
https://dn42.bauen1.xyz/

             reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 19:05 bauen1 [this message]
2020-07-29 21:02 ` James Carter
2020-09-03 18:15   ` James Carter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12fc8da1-4fbd-59f7-08e7-0af9daff118c@gmail.com \
    --to=j2468h@googlemail.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux/0 selinux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux selinux/ https://lore.kernel.org/selinux \
		selinux@vger.kernel.org
	public-inbox-index selinux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git