From: Paul Moore <pmoore@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Andy King <acking@vmware.com>,
netdev@vger.kernel.org, linux-security-module@vger.kernel.org,
selinux@tycho.nsa.gov, Eric Paris <eparis@redhat.com>
Subject: Re: AF_VSOCK and the LSMs
Date: Mon, 25 Feb 2013 10:06:20 -0500 [thread overview]
Message-ID: <14339054.TIbCY6PHR8@sifl> (raw)
In-Reply-To: <512B12EA.1000003@redhat.com>
On Monday, February 25, 2013 08:29:46 AM Gerd Hoffmann wrote:
> Hi,
Hello.
> >> I think perhaps this is the wrong layer at which to embed this. Think
> >> of that structure as an ethernet header, with VMCI being ethernet; it's
> >> what the device (and the hypervisor and peer) understand. So this
> >> really cannot be changed.
> >
> > Hmmm, so can VMware/VMCI-enabled guests send vmci_datagram packets
> > directly into the kernel? It isn't wrapped by things like AF_VSOCK? If
> > that is the case, then yes, we'll probably need to add a thin wrapper
> > struct to carry the security label; similar to the control packets but not
> > quite, as we have data to deal with unlike the control packets. However,
> > if vmci_datagram is an internal only structure, why not add the extra
> > field?
>
> vmci_datagram is part of the guest/host ABI I think.
>
> Data flow looks like this:
>
> (1) guest application opens a AF_VSOCK socket
> (2) guest sends data as usual (say send syscall).
> (3) vsock core hards over the packet to the transport layer
>
> (only vmci atm, but we wanna add virtio here).
>
> (4) transport layer passes data to the hypervisor (vmci uses a
>
> virtual pci device for that, virtio will do the same).
> ...
Okay, I think I found the core of my misunderstanding: I was under the
impression that the AF_VSOCK layer lived in the host kernel, not the guest
kernel.
With the VS_VSOCK layer in the guest kernel this all becomes much less
interesting. I'll take another look today, but I think the only changes we
probably want to make are with SELinux - the "virt_socket" object class - so
we can control which applications in the guest can use AF_VSOCK sockets. I
don't think we will need any changes to Smack but I'll take a closer look.
Also, all the changes I suggested earlier to VMCI aren't necessary; as you and
Andy point out, this is the wrong layer - we can't do a whole lot of
meaningful enforcement in the guest.
Thanks for the clarification.
-Paul
--
paul moore
security and virtualization @ redhat
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
prev parent reply other threads:[~2013-02-25 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 22:33 AF_VSOCK and the LSMs Paul Moore
2013-02-22 23:00 ` Casey Schaufler
2013-02-23 0:45 ` Paul Moore
2013-02-23 23:43 ` Casey Schaufler
2013-02-25 16:55 ` Paul Moore
2013-02-25 18:02 ` Casey Schaufler
2013-02-25 21:05 ` Paul Moore
2013-02-25 23:06 ` Casey Schaufler
2013-02-26 21:21 ` LSM stacking and the network access controls (was: AF_VSOCK and the LSMs) Paul Moore
2013-02-26 23:12 ` LSM stacking and the network access controls Casey Schaufler
2013-02-27 16:43 ` Paul Moore
2013-02-27 16:51 ` Casey Schaufler
2013-02-27 17:31 ` Paul Moore
2013-02-27 17:40 ` Casey Schaufler
[not found] ` <888679886.3769933.1361573683299.JavaMail.root@vmware.com>
2013-02-23 0:27 ` AF_VSOCK and the LSMs Paul Moore
[not found] ` <512B12EA.1000003@redhat.com>
2013-02-25 15:06 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14339054.TIbCY6PHR8@sifl \
--to=pmoore@redhat.com \
--cc=acking@vmware.com \
--cc=eparis@redhat.com \
--cc=kraxel@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).