selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Richard Haines <richard_c_haines@btinternet.com>,
	selinux@vger.kernel.org
Subject: Re: [RFC PATCH] selinux-testsuite: Add TUN/TAP driver tests
Date: Mon, 2 Dec 2019 09:20:04 -0500	[thread overview]
Message-ID: <1be772e5-2c78-2f00-b996-04ae1592001a@tycho.nsa.gov> (raw)
In-Reply-To: <2f41698ed14a640481fcc82476cd9c725e3d17e6.camel@btinternet.com>

On 11/28/19 7:53 AM, Richard Haines wrote:
> I'll change this (I try to avoid interfaces in tests as you need to
> lookup what they really contain and it may be more than you want, plus
> just plain allow rules are much clearer (but that's just me))

I'd agree if the interface is a poor match / overly broad but I think in 
this case it works well.  I am sympathetic to the view that refpolicy 
interfaces are harder to use than raw policy rules (hence the almost 
complete lack of interfaces aside from common macros in the Android 
policy), but the one advantage they should carry is greater portability 
across refpolicy versions since they should automatically pick up 
changes in the base policy (e.g. if a type is renamed or split or 
coalesced, if a new permission besides the one being tested is 
introduced and needed for the abstract operation, etc).  And if/when we 
transition refpolicy to a truly higher level policy language on top of 
CIL, then I would anticipate them providing greater benefits as first 
class abstractions rather than mere m4 macros. But I guess only time 
will tell...

      reply	other threads:[~2019-12-02 14:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  9:47 [RFC PATCH] selinux-testsuite: Add TUN/TAP driver tests Richard Haines
2019-11-27 14:59 ` Stephen Smalley
2019-11-28 12:53   ` Richard Haines
2019-12-02 14:20     ` Stephen Smalley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1be772e5-2c78-2f00-b996-04ae1592001a@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=richard_c_haines@btinternet.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).