From: Vit Mojzis <vmojzis@redhat.com>
To: Stephen Smalley <sds@tycho.nsa.gov>, selinux@vger.kernel.org
Subject: Re: [PATCH] policycoreutils/fixfiles: Fix "verify" option
Date: Tue, 24 Sep 2019 08:51:26 +0200 [thread overview]
Message-ID: <1eaf887d-8ff5-0436-60b1-8dace27359df@redhat.com> (raw)
In-Reply-To: <f9727681-817e-ba7a-7ba7-7837bf7f0212@tycho.nsa.gov>
On 9/23/19 5:08 PM, Stephen Smalley wrote:
> On 9/23/19 10:43 AM, Vit Mojzis wrote:
>> "restorecon -n" (used in the "restore" function) has to be used with
>> "-v" to display the files whose labels would be changed.
>>
>> Fixes:
>> Fixfiles verify does not report misslabelled files unless "-v"
>> option is
>> used.
>
> Please add a Signed-off-by line. With this change, aside from display
> "Verifying" vs. "Checking" there seems to be no difference between
> fixfiles verify and fixfiles check? Wondering if there was some
> difference originally?
>
Apparently "Verify" used to call "restorecon -n -o -", but "-o" is now
obsolete. You are right, "Verify" and "Check" do the same thing now.
>> ---
>> policycoreutils/scripts/fixfiles | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/policycoreutils/scripts/fixfiles
>> b/policycoreutils/scripts/fixfiles
>> index 5be9ba6e..1a31e061 100755
>> --- a/policycoreutils/scripts/fixfiles
>> +++ b/policycoreutils/scripts/fixfiles
>> @@ -302,7 +302,7 @@ process() {
>> case "$1" in
>> restore) restore Relabel;;
>> check) VERBOSE="-v"; restore Check -n;;
>> - verify) restore Verify -n;;
>> + verify) VERBOSE="-v"; restore Verify -n;;
>> relabel) relabel;;
>> onboot)
>> if [ "$RESTORE_MODE" != DEFAULT ]; then
>>
>
prev parent reply other threads:[~2019-09-24 6:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 14:43 [PATCH] policycoreutils/fixfiles: Fix "verify" option Vit Mojzis
2019-09-23 15:08 ` Stephen Smalley
2019-09-24 6:41 ` Vit Mojzis
2019-09-26 12:24 ` Stephen Smalley
2019-09-24 6:51 ` Vit Mojzis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1eaf887d-8ff5-0436-60b1-8dace27359df@redhat.com \
--to=vmojzis@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).