From: Jason Zaman <jason@perfinion.com>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH 1/2] python/sepolicy: drop python shebang from the module
Date: Mon, 18 Feb 2019 21:01:34 +0800 [thread overview]
Message-ID: <20190218130134.GA48250@baraddur.perfinion.com> (raw)
In-Reply-To: <20190217213650.25974-1-nicolas.iooss@m4x.org>
On Sun, Feb 17, 2019 at 10:36:49PM +0100, Nicolas Iooss wrote:
> The files in sepolicy's module directory are not supposed to used as
> executable files. The shebang line is therefore not needed.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
For both these patches:
Acked-by: Jason Zaman <jason@perfinion.com>
> ---
> python/sepolicy/sepolicy/__init__.py | 2 --
> python/sepolicy/sepolicy/booleans.py | 1 -
> python/sepolicy/sepolicy/communicate.py | 1 -
> python/sepolicy/sepolicy/generate.py | 2 --
> python/sepolicy/sepolicy/gui.py | 2 --
> python/sepolicy/sepolicy/interface.py | 2 --
> python/sepolicy/sepolicy/manpage.py | 1 -
> python/sepolicy/sepolicy/network.py | 1 -
> python/sepolicy/sepolicy/transition.py | 1 -
> 9 files changed, 13 deletions(-)
>
> diff --git a/python/sepolicy/sepolicy/__init__.py b/python/sepolicy/sepolicy/__init__.py
> index 6f7294726be4..6aed31bddf1e 100644
> --- a/python/sepolicy/sepolicy/__init__.py
> +++ b/python/sepolicy/sepolicy/__init__.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/python
> -
> # Author: Dan Walsh <dwalsh@redhat.com>
> # Author: Ryan Hallisey <rhallise@redhat.com>
> # Author: Jason Zaman <perfinion@gentoo.org>
> diff --git a/python/sepolicy/sepolicy/booleans.py b/python/sepolicy/sepolicy/booleans.py
> index cf5f1ffc6469..ad07ab045d3e 100644
> --- a/python/sepolicy/sepolicy/booleans.py
> +++ b/python/sepolicy/sepolicy/booleans.py
> @@ -1,4 +1,3 @@
> -#! /usr/bin/python -Es
> # Copyright (C) 2012 Red Hat
> # see file 'COPYING' for use and warranty information
> #
> diff --git a/python/sepolicy/sepolicy/communicate.py b/python/sepolicy/sepolicy/communicate.py
> index 299316e0bf27..374002204f84 100755
> --- a/python/sepolicy/sepolicy/communicate.py
> +++ b/python/sepolicy/sepolicy/communicate.py
> @@ -1,4 +1,3 @@
> -#! /usr/bin/python -Es
> # Copyright (C) 2012 Red Hat
> # see file 'COPYING' for use and warranty information
> #
> diff --git a/python/sepolicy/sepolicy/generate.py b/python/sepolicy/sepolicy/generate.py
> index 5a2195b8033f..019e7836c597 100644
> --- a/python/sepolicy/sepolicy/generate.py
> +++ b/python/sepolicy/sepolicy/generate.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/python -Es
> -#
> # Copyright (C) 2007-2012 Red Hat
> # see file 'COPYING' for use and warranty information
> #
> diff --git a/python/sepolicy/sepolicy/gui.py b/python/sepolicy/sepolicy/gui.py
> index d4bf3b48e629..00fd7a11dab8 100644
> --- a/python/sepolicy/sepolicy/gui.py
> +++ b/python/sepolicy/sepolicy/gui.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/python -Es
> -#
> # Copyright (C) 2013 Red Hat
> # see file 'COPYING' for use and warranty information
> #
> diff --git a/python/sepolicy/sepolicy/interface.py b/python/sepolicy/sepolicy/interface.py
> index 27c37bb8e1f8..583091ae18aa 100644
> --- a/python/sepolicy/sepolicy/interface.py
> +++ b/python/sepolicy/sepolicy/interface.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/python -Es
> -#
> # Copyright (C) 2012 Red Hat
> # see file 'COPYING' for use and warranty information
> #
> diff --git a/python/sepolicy/sepolicy/manpage.py b/python/sepolicy/sepolicy/manpage.py
> index af18b6ffc12f..1d367962365a 100755
> --- a/python/sepolicy/sepolicy/manpage.py
> +++ b/python/sepolicy/sepolicy/manpage.py
> @@ -1,4 +1,3 @@
> -#! /usr/bin/python -Es
> # Copyright (C) 2012-2013 Red Hat
> # AUTHOR: Dan Walsh <dwalsh@redhat.com>
> # AUTHOR: Miroslav Grepl <mgrepl@redhat.com>
> diff --git a/python/sepolicy/sepolicy/network.py b/python/sepolicy/sepolicy/network.py
> index 115f6b8778d5..34267d929b0d 100755
> --- a/python/sepolicy/sepolicy/network.py
> +++ b/python/sepolicy/sepolicy/network.py
> @@ -1,4 +1,3 @@
> -#! /usr/bin/python -Es
> # Copyright (C) 2012 Red Hat
> # see file 'COPYING' for use and warranty information
> #
> diff --git a/python/sepolicy/sepolicy/transition.py b/python/sepolicy/sepolicy/transition.py
> index 7dea80597dc1..6414a765d0fa 100755
> --- a/python/sepolicy/sepolicy/transition.py
> +++ b/python/sepolicy/sepolicy/transition.py
> @@ -1,4 +1,3 @@
> -#! /usr/bin/python -Es
> # Copyright (C) 2011 Red Hat
> # see file 'COPYING' for use and warranty information
> #
> --
> 2.20.1
>
prev parent reply other threads:[~2019-02-18 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-17 21:36 [PATCH 1/2] python/sepolicy: drop python shebang from the module Nicolas Iooss
2019-02-17 21:36 ` [PATCH 2/2] python: always use python3 in the shebang of programs using setools Nicolas Iooss
2019-02-18 13:01 ` Petr Lautrbach
2019-02-20 10:07 ` Petr Lautrbach
2019-02-18 13:01 ` [PATCH 1/2] python/sepolicy: drop python shebang from the module Petr Lautrbach
2019-02-18 13:01 ` Jason Zaman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190218130134.GA48250@baraddur.perfinion.com \
--to=jason@perfinion.com \
--cc=nicolas.iooss@m4x.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).