selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Bad file pattern in MAINTAINERS section 'SELINUX SECURITY MODULE'
       [not found] <7cd8d12f59bcacd18a78f599b46dac555f7f16c0.camel@perches.com>
@ 2019-03-25 21:27 ` Joe Perches
  2019-03-25 21:58   ` [PATCH] " Casey Schaufler
  0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2019-03-25 21:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: Paul Moore, Stephen Smalley, Eric Paris, selinux, Joe Perches,
	Casey Schaufler, Kees Cook

A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.

This could occur because a matching filename was never added, was deleted
or renamed in some other commit.

The commits that added and if found renamed or removed the file pattern
are shown below.

Please fix this defect appropriately.

1: ---------------------------------------------------------------------------

linux-next MAINTAINERS section:

	13949	SELINUX SECURITY MODULE
	13950	M:	Paul Moore <paul@paul-moore.com>
	13951	M:	Stephen Smalley <sds@tycho.nsa.gov>
	13952	M:	Eric Paris <eparis@parisplace.org>
	13953	L:	selinux@vger.kernel.org
	13954	W:	https://selinuxproject.org
	13955	W:	https://github.com/SELinuxProject
	13956	T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git
	13957	S:	Supported
-->	13958	F:	include/linux/selinux*
	13959	F:	security/selinux/
	13960	F:	scripts/selinux/
	13961	F:	Documentation/admin-guide/LSM/SELinux.rst

2: ---------------------------------------------------------------------------

The most recent commit that added or modified file pattern 'include/linux/selinux*':

commit 679655daffdd2725b66ba2c5a759bbcb316fca5a
Author: Joe Perches <joe@perches.com>
Date:   Tue Apr 7 20:44:32 2009 -0700

    MAINTAINERS - Add file patterns
    
    Better description of file pattern tag "F:"
    Add file exclusion tag "X:"
    Add patterns to sections
    
    Signed-off-by: Joe Perches <joe@perches.com>

 MAINTAINERS | 1194 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 1193 insertions(+), 1 deletion(-)

3: ---------------------------------------------------------------------------

The last commit with a real presence of file pattern 'include/linux/selinux*':

commit 3d252529480c68bfd6a6774652df7c8968b28e41
Author: Casey Schaufler <casey@schaufler-ca.com>
Date:   Fri Sep 21 17:17:34 2018 -0700

    SELinux: Remove unused selinux_is_enabled
    
    There are no longer users of selinux_is_enabled().
    Remove it. As selinux_is_enabled() is the only reason
    for include/linux/selinux.h remove that as well.
    
    Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
    Reviewed-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Kees Cook <keescook@chromium.org>

 include/linux/cred.h             |  1 -
 include/linux/selinux.h          | 35 -----------------------------------
 security/selinux/Makefile        |  2 +-
 security/selinux/exports.c       | 23 -----------------------
 security/selinux/hooks.c         |  1 -
 security/selinux/include/audit.h |  3 ---
 security/selinux/ss/services.c   |  1 -
 7 files changed, 1 insertion(+), 65 deletions(-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Bad file pattern in MAINTAINERS section 'SELINUX SECURITY MODULE'
  2019-03-25 21:27 ` Bad file pattern in MAINTAINERS section 'SELINUX SECURITY MODULE' Joe Perches
@ 2019-03-25 21:58   ` Casey Schaufler
  2019-03-25 22:02     ` Joe Perches
  0 siblings, 1 reply; 4+ messages in thread
From: Casey Schaufler @ 2019-03-25 21:58 UTC (permalink / raw)
  To: Joe Perches, linux-kernel
  Cc: Paul Moore, Stephen Smalley, Eric Paris, selinux, Kees Cook

The include/linux/selinux.h file has been removed.
Remove the entry from the MAINTAINERS file.

Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
---
  MAINTAINERS | 1 -
  1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3e5a5d263f29..1039c34dff3c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13947,7 +13947,6 @@ W:	https://selinuxproject.org
  W:	https://github.com/SELinuxProject
  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git
  S:	Supported
-F:	include/linux/selinux*
  F:	security/selinux/
  F:	scripts/selinux/
  F:	Documentation/admin-guide/LSM/SELinux.rst


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bad file pattern in MAINTAINERS section 'SELINUX SECURITY MODULE'
  2019-03-25 21:58   ` [PATCH] " Casey Schaufler
@ 2019-03-25 22:02     ` Joe Perches
  2019-03-25 22:22       ` Casey Schaufler
  0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2019-03-25 22:02 UTC (permalink / raw)
  To: Casey Schaufler, linux-kernel
  Cc: Paul Moore, Stephen Smalley, Eric Paris, selinux, Kees Cook

On Mon, 2019-03-25 at 14:58 -0700, Casey Schaufler wrote:
> The include/linux/selinux.h file has been removed.
> Remove the entry from the MAINTAINERS file.

This looks like it doesn't apply correctly as there
are one too many spaces before each context lines.

> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
>   MAINTAINERS | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3e5a5d263f29..1039c34dff3c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13947,7 +13947,6 @@ W:	https://selinuxproject.org
>   W:	https://github.com/SELinuxProject
>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git
>   S:	Supported
> -F:	include/linux/selinux*
>   F:	security/selinux/
>   F:	scripts/selinux/
>   F:	Documentation/admin-guide/LSM/SELinux.rst
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Bad file pattern in MAINTAINERS section 'SELINUX SECURITY MODULE'
  2019-03-25 22:02     ` Joe Perches
@ 2019-03-25 22:22       ` Casey Schaufler
  0 siblings, 0 replies; 4+ messages in thread
From: Casey Schaufler @ 2019-03-25 22:22 UTC (permalink / raw)
  To: Joe Perches, linux-kernel
  Cc: Paul Moore, Stephen Smalley, Eric Paris, selinux, Kees Cook

On 3/25/2019 3:02 PM, Joe Perches wrote:
> On Mon, 2019-03-25 at 14:58 -0700, Casey Schaufler wrote:
>> The include/linux/selinux.h file has been removed.
>> Remove the entry from the MAINTAINERS file.
> This looks like it doesn't apply correctly as there
> are one too many spaces before each context lines.

Oops. New version of Thunderbird. Looks like there's
configuration tuning required. I'll try again


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-25 22:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <7cd8d12f59bcacd18a78f599b46dac555f7f16c0.camel@perches.com>
2019-03-25 21:27 ` Bad file pattern in MAINTAINERS section 'SELINUX SECURITY MODULE' Joe Perches
2019-03-25 21:58   ` [PATCH] " Casey Schaufler
2019-03-25 22:02     ` Joe Perches
2019-03-25 22:22       ` Casey Schaufler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).