From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5DBC43219 for ; Mon, 29 Apr 2019 12:40:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C1502075E for ; Mon, 29 Apr 2019 12:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556541606; bh=VtuGZoYAnKngnQl6eSlPBIWIFDPiV3IsR61xIGjAPoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IXofStErGmigI3VXV+x3alvLABt0seWr8b4YM1C4L/2+QPjg1/I7/3sYzApvKQDmy kSUCftUp682Zkm1SL3s2yPgGMqMVsldp8lEje26e+44P8YXGuN7ACd0vw1Xk0ce+VO zS9Vsly3WxQ5WnAZXrykPuRXQt7h9ilg9YC9TqwY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728071AbfD2MkG (ORCPT ); Mon, 29 Apr 2019 08:40:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:53800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728064AbfD2MkF (ORCPT ); Mon, 29 Apr 2019 08:40:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D50F20675; Mon, 29 Apr 2019 12:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556541604; bh=VtuGZoYAnKngnQl6eSlPBIWIFDPiV3IsR61xIGjAPoQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HcOdIHbrrIuYNujm4j1RkPmc0CIC4upR6h2eV5sF2giw8Pwliv/T9s/R6oKimnoPV npaSLjP2hL6+x4owcKCkRO2Pailg9bo+KBORGogRi1VISQ6u7ERMToe4LkQOdGpLFG QtlBsqu2lY86JJswc7FH3B2WUoul6mH6EHW7RZPI= Date: Mon, 29 Apr 2019 14:40:02 +0200 From: Greg KH To: Paul Moore Cc: Sasha Levin , Nathan Chancellor , Stephen Smalley , Eric Paris , selinux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nicolas Iooss Subject: Re: scripts/selinux build error in 4.14 after glibc update Message-ID: <20190429124002.GB31371@kroah.com> References: <20190422210041.GA21711@archlinux-i9> <20190423132926.GK17719@sasha-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Tue, Apr 23, 2019 at 09:43:09AM -0400, Paul Moore wrote: > On Tue, Apr 23, 2019 at 9:29 AM Sasha Levin wrote: > > On Mon, Apr 22, 2019 at 09:59:47PM -0400, Paul Moore wrote: > > >On Mon, Apr 22, 2019 at 5:00 PM Nathan Chancellor > > > wrote: > > >> Hi all, > > >> > > >> After a glibc update to 2.29, my 4.14 builds started failing like so: > > > > > >... > > > > > >> HOSTCC scripts/selinux/genheaders/genheaders > > >> In file included from scripts/selinux/genheaders/genheaders.c:19: > > >> ./security/selinux/include/classmap.h:245:2: error: #error New address family defined, please update secclass_map. > > >> #error New address family defined, please update secclass_map. > > >> ^~~~~ > > > > > >This is a known problem that has a fix in the selinux/next branch and > > >will be going up to Linus during the next merge window. The fix is > > >quite small and should be relatively easy for you to backport to your > > >kernel build if you are interested; the patch can be found at the > > >archive link below: > > > > > >https://lore.kernel.org/selinux/20190225005528.28371-1-paulo@paulo.ac > > > > Why is it waiting for the next merge window? It fixes a build bug that > > people hit. > > I place a reasonably high bar on patches that I send up to Linus > outside of the merge window and I didn't feel this patch met that > criteria. Nathan is only the second person I've seen who has > encountered this problem, the first being the original patch author. > As far as I've seen, the problem is only seen by users building older > kernels on very new userspaces (e.g. glibc v2.29 was released in > February 2019, Linux v4.14 was released in 2017); this doesn't appear > to be a large group of people and I didn't want to risk breaking the > main kernel tree during the -rcX phase for such a small group. Ugh, this breaks my local builds, I would recommend getting it to Linus sooner please. thanks, greg k-h